feat(test-data): create StandalonePrice model and associated draft
#472
Conversation
jaikamat
requested review from
Sarah4VT,
jmcreasman,
kterry1 and
valoriecarli
and removed request for
a team
🦋 Changeset detectedLatest commit: 4b60553 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| ): TReferenceGraphql<'customer-group'>; | ||
|
|
||
| // Create a customer group reference depending on `id` or `key` field availability | ||
| function createCustomerGroupReference( |
There was a problem hiding this comment.
key is optional in CustomerGroup - I wanted consumers to get the type of reference they intended, so I opted to create a KeyReference if key was provided, otherwise create an id Reference (rather than defaulting to an id Reference)
| discounted: null, | ||
| staged: null, |
There was a problem hiding this comment.
Both of these models (DiscountedPrice and StagedStandalonePrice) are not necessary for our effort and were omitted from creation, in the interest of time
jaikamat
removed request for
a team,
Sarah4VT,
jmcreasman,
kterry1 and
valoriecarli
| // Remove `expiresAt` from the fields | ||
| const { expiresAt, ...rest } = fields; |
There was a problem hiding this comment.
sheer curiosity: do we know why these two representations deviate with this field?
There was a problem hiding this comment.
Code looks good. Maybe an unknown piece but there are models inside the priceless repo.
models/standalone-price/src/standalone-price-draft/builder.spec.ts
Outdated
Show resolved
Hide resolved
In the long run, our idea is to replace those linked models with |
Summary
This PR creates the
StandalonePricemodel and associated draft for use with our B2B dataset support effort.Standalone prices REST documentation
Graphql structure:
Base model:
Draft model: