Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test-data): correct PaymentDraft model generation #477

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

jaikamat
Copy link
Contributor

@jaikamat jaikamat commented Feb 6, 2024

Summary

While making changes related to this effort, I found that PaymentDraft was not being generated correctly

@jaikamat jaikamat added the bug Something isn't working label Feb 6, 2024
@jaikamat jaikamat self-assigned this Feb 6, 2024
@jaikamat jaikamat requested a review from a team as a code owner February 6, 2024 20:30
Copy link

changeset-bot bot commented Feb 6, 2024

🦋 Changeset detected

Latest commit: dbabd97

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@commercetools-test-data/payment Patch
@commercetools-test-data/core Patch
@commercetools-test-data/graphql-types Patch
@commercetools-test-data/associate-role Patch
@commercetools-test-data/business-unit Patch
@commercetools-test-data/cart-discount Patch
@commercetools-test-data/cart Patch
@commercetools-test-data/category Patch
@commercetools-test-data/channel Patch
@commercetools-test-data/commons Patch
@commercetools-test-data/custom-object Patch
@commercetools-test-data/custom-view Patch
@commercetools-test-data/customer-group Patch
@commercetools-test-data/customer Patch
@commercetools-test-data/discount-code Patch
@commercetools-test-data/inventory-entry Patch
@commercetools-test-data/order Patch
@commercetools-test-data/product-discount Patch
@commercetools-test-data/product-selection Patch
@commercetools-test-data/product-type Patch
@commercetools-test-data/product Patch
@commercetools-test-data/quote-request Patch
@commercetools-test-data/quote Patch
@commercetools-test-data/review Patch
@commercetools-test-data/shipping-method Patch
@commercetools-test-data/shopping-list Patch
@commercetools-test-data/staged-quote Patch
@commercetools-test-data/standalone-price Patch
@commercetools-test-data/state Patch
@commercetools-test-data/store Patch
@commercetools-test-data/tax-category Patch
@commercetools-test-data/type Patch
@commercetools-test-data/zone Patch
@commercetools-test-data/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@ByronDWall ByronDWall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the schema docs in impex, lgtm

Copy link
Contributor

@tylermorrisford tylermorrisford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😶‍🌫️

@jaikamat jaikamat merged commit 963eac6 into main Feb 6, 2024
3 checks passed
@jaikamat jaikamat deleted the FCT-fix-payment-draft branch February 6, 2024 20:43
@ct-changesets ct-changesets bot mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants