-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PANGOLIN-3515 - CH MoneyDraft & Payment presets #488
Conversation
🦋 Changeset detectedLatest commit: f617d44 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Approving but do want to see the follow up happen in https://commercetools.atlassian.net/browse/PANGOLIN-3488 as I suspect we can get rid of the withUsdCurrencyCodeCentMax if we update the MoneyDraft generator to only generate values that can possibly be stored in the database and be accepted by the coco api. If we know this is a needed global fix, we shouldn't contain it to just our presets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
The following is covered in this PR:
withUsdCurrencyCode
to accommodate recent fixes to toPaymentStatus
of the last major release.withUsdCurrencyCodeCentMax
preset for CHMoneyDraft
withUsdCurrencyCodeCentMax
preset intoPaymentDraft.amountPlanned
, as this was also causing anInt cannot represent non 32-bit signed integer value
error (discovered onceTransaction.amount
was settled).