Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PANGOLIN-3515 - CH MoneyDraft & Payment presets #488

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

valoriecarli
Copy link
Contributor

The following is covered in this PR:

  • Adjustment to the CH PaymentDraft preset withUsdCurrencyCode to accommodate recent fixes to to PaymentStatus of the last major release.
  • Further narrowing down of a the withUsdCurrencyCodeCentMax preset for CH MoneyDraft
  • Pull the withUsdCurrencyCodeCentMax preset into PaymentDraft.amountPlanned, as this was also causing an Int cannot represent non 32-bit signed integer value error (discovered once Transaction.amount was settled).

@valoriecarli valoriecarli requested review from a team as code owners February 23, 2024 15:23
Copy link

changeset-bot bot commented Feb 23, 2024

🦋 Changeset detected

Latest commit: f617d44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@commercetools-test-data/commons Patch
@commercetools-test-data/payment Patch
@commercetools-test-data/associate-role Patch
@commercetools-test-data/business-unit Patch
@commercetools-test-data/cart-discount Patch
@commercetools-test-data/cart Patch
@commercetools-test-data/category Patch
@commercetools-test-data/channel Patch
@commercetools-test-data/custom-object Patch
@commercetools-test-data/custom-view Patch
@commercetools-test-data/customer-group Patch
@commercetools-test-data/customer Patch
@commercetools-test-data/discount-code Patch
@commercetools-test-data/inventory-entry Patch
@commercetools-test-data/order Patch
@commercetools-test-data/product-discount Patch
@commercetools-test-data/product-selection Patch
@commercetools-test-data/product-type Patch
@commercetools-test-data/product Patch
@commercetools-test-data/quote-request Patch
@commercetools-test-data/quote Patch
@commercetools-test-data/review Patch
@commercetools-test-data/shipping-method Patch
@commercetools-test-data/shopping-list Patch
@commercetools-test-data/staged-quote Patch
@commercetools-test-data/standalone-price Patch
@commercetools-test-data/state Patch
@commercetools-test-data/store Patch
@commercetools-test-data/tax-category Patch
@commercetools-test-data/type Patch
@commercetools-test-data/zone Patch
@commercetools-test-data/core Patch
@commercetools-test-data/graphql-types Patch
@commercetools-test-data/project Patch
@commercetools-test-data/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@valoriecarli valoriecarli requested review from Sarah4VT, jmcreasman and kterry1 and removed request for a team February 23, 2024 15:23
@valoriecarli valoriecarli self-assigned this Feb 23, 2024
@Sarah4VT
Copy link
Contributor

Approving but do want to see the follow up happen in https://commercetools.atlassian.net/browse/PANGOLIN-3488 as I suspect we can get rid of the withUsdCurrencyCodeCentMax if we update the MoneyDraft generator to only generate values that can possibly be stored in the database and be accepted by the coco api. If we know this is a needed global fix, we shouldn't contain it to just our presets.

@valoriecarli valoriecarli merged commit 9e7e964 into main Feb 23, 2024
3 checks passed
@valoriecarli valoriecarli deleted the PANGOLIN-3515-money-preset branch February 23, 2024 16:57
@ct-changesets ct-changesets bot mentioned this pull request Feb 23, 2024
Copy link
Contributor

@jmcreasman jmcreasman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants