-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEC-39: Fix models related to Batch 2 (Part 1) #650
Conversation
🦋 Changeset detectedLatest commit: 69950ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 47 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@jaikumar-tj please bear in mind the |
custom: null, | ||
}; | ||
export const restFieldsConfig: TModelFieldsConfig<TInventoryEntryRest> = { | ||
fields: { | ||
...commonFieldsConfig, | ||
supplyChannel: fake(() => Reference.presets.channelReference()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just populate required attributes and this one is optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Summary
In this PR, there are 3 main changes that are done to the existing models in the project. The changes are related to the
commons
,inventory-entry
, andproduct-type
models.Common
discounted-price
Inventory Entry
supplyChannel
, making it optionalProduct Type