Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEC-39: Fix models related to Batch 2 (Part 1) #650

Merged
merged 11 commits into from
Dec 5, 2024

Conversation

jaikumar-tj
Copy link
Contributor

@jaikumar-tj jaikumar-tj commented Aug 27, 2024

Summary

In this PR, there are 3 main changes that are done to the existing models in the project. The changes are related to the commons, inventory-entry, and product-type models.

Common

  • Introduced a new model called discounted-price

Inventory Entry

  • Updated the transformer file to conditionally send the supplyChannel, making it optional

Product Type

  • Added new presets for enum and localized enum types

@jaikumar-tj jaikumar-tj added 🚧 Status: WIP fe-chapter-rotation Tasks coming from frontend chapter work labels Aug 27, 2024
@jaikumar-tj jaikumar-tj self-assigned this Aug 27, 2024
Copy link

changeset-bot bot commented Aug 27, 2024

🦋 Changeset detected

Latest commit: 69950ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 47 packages
Name Type
@commercetools-test-data/product-type Minor
@commercetools-test-data/commons Minor
@commercetools-test-data/inventory-entry Minor
@commercetools-test-data/cart-discount Minor
@commercetools-test-data/product-discount Minor
@commercetools-test-data/product-projection Minor
@commercetools-test-data/product Minor
@commercetools-test-data/associate-role Minor
@commercetools-test-data/attribute-group Minor
@commercetools-test-data/business-unit Minor
@commercetools-test-data/cart Minor
@commercetools-test-data/category Minor
@commercetools-test-data/channel Minor
@commercetools-test-data/custom-application Minor
@commercetools-test-data/custom-object Minor
@commercetools-test-data/custom-view Minor
@commercetools-test-data/customer-group Minor
@commercetools-test-data/customer Minor
@commercetools-test-data/customers-search-list-my-view Minor
@commercetools-test-data/discount-code Minor
@commercetools-test-data/discounts-custom-view Minor
@commercetools-test-data/order Minor
@commercetools-test-data/organization Minor
@commercetools-test-data/payment Minor
@commercetools-test-data/platform-limits Minor
@commercetools-test-data/product-selection Minor
@commercetools-test-data/quote-request Minor
@commercetools-test-data/quote Minor
@commercetools-test-data/review Minor
@commercetools-test-data/shipping-method Minor
@commercetools-test-data/shopping-list Minor
@commercetools-test-data/staged-quote Minor
@commercetools-test-data/standalone-price Minor
@commercetools-test-data/state Minor
@commercetools-test-data/store Minor
@commercetools-test-data/tax-category Minor
@commercetools-test-data/type Minor
@commercetools-test-data/user Minor
@commercetools-test-data/zone Minor
@commercetools-test-data/organization-extension Minor
@commercetools-test-data/project-extension Minor
@commercetools-test-data/core Minor
@commercetools-test-data/graphql-types Minor
@commercetools-test-data/filter-values Minor
@commercetools-test-data/project Minor
@commercetools-test-data/utils Minor
@commercetools-test-data/generators Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jaikumar-tj jaikumar-tj changed the title FEC-39: Fix models related to Batch 2 FEC-39: Fix models related to Batch 2 (Part 1) Aug 27, 2024
@CarlosCortizasCT
Copy link
Contributor

@jaikumar-tj please bear in mind the InventoryEntry model is already being updated for the same reason in this already opened PR.

@CarlosCortizasCT CarlosCortizasCT marked this pull request as ready for review December 5, 2024 11:31
@CarlosCortizasCT CarlosCortizasCT requested review from a team as code owners December 5, 2024 11:31
custom: null,
};
export const restFieldsConfig: TModelFieldsConfig<TInventoryEntryRest> = {
fields: {
...commonFieldsConfig,
supplyChannel: fake(() => Reference.presets.channelReference()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just populate required attributes and this one is optional.

Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@CarlosCortizasCT CarlosCortizasCT merged commit 8038c61 into main Dec 5, 2024
4 checks passed
@CarlosCortizasCT CarlosCortizasCT deleted the FEC-39-test-data-migration-batch-2 branch December 5, 2024 12:54
@ct-changesets ct-changesets bot mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fe-chapter-rotation Tasks coming from frontend chapter work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants