-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test-data): narrowly introspect scalar types #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaikamat
requested review from
ddouglasz,
tylermorrisford,
ByronDWall and
misama-ct
and removed request for
a team
December 20, 2024 16:16
🦋 Changeset detectedLatest commit: a9d91e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 47 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ByronDWall
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes sure look like changes to me
stephsprinkle
approved these changes
Dec 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR edits the codegen config file to prefer more specific types rather than
unknown
for scalar values.This work was prompted by a lack of backwards compatibility from the new changes to test-data fixtures with respect to the B2B sample import, in which
unknown
values could not be assigned to more narrow preset-defined types likestring
.Since scalar types are now inferred more narrowly, the test-data fixture types and those same types introspected in mc-services should be identical and compatible.
Merging this in and cutting a new version will allow us to make more streamlined changes in mc-services to update the B2B feature.