Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test-data): narrowly introspect scalar types #730

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

jaikamat
Copy link
Contributor

@jaikamat jaikamat commented Dec 20, 2024

Summary

This PR edits the codegen config file to prefer more specific types rather than unknown for scalar values.

This work was prompted by a lack of backwards compatibility from the new changes to test-data fixtures with respect to the B2B sample import, in which unknown values could not be assigned to more narrow preset-defined types like string.

Since scalar types are now inferred more narrowly, the test-data fixture types and those same types introspected in mc-services should be identical and compatible.

Merging this in and cutting a new version will allow us to make more streamlined changes in mc-services to update the B2B feature.

@jaikamat jaikamat self-assigned this Dec 20, 2024
@jaikamat jaikamat requested a review from a team as a code owner December 20, 2024 16:16
@jaikamat jaikamat requested review from ddouglasz, tylermorrisford, ByronDWall and misama-ct and removed request for a team December 20, 2024 16:16
Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: a9d91e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 47 packages
Name Type
@commercetools-test-data/graphql-types Patch
@commercetools-test-data/cart Patch
@commercetools-test-data/channel Patch
@commercetools-test-data/commons Patch
@commercetools-test-data/custom-application Patch
@commercetools-test-data/custom-view Patch
@commercetools-test-data/customers-search-list-my-view Patch
@commercetools-test-data/discounts-custom-view Patch
@commercetools-test-data/filter-values Patch
@commercetools-test-data/inventory-entry Patch
@commercetools-test-data/organization-extension Patch
@commercetools-test-data/organization Patch
@commercetools-test-data/project-extension Patch
@commercetools-test-data/user Patch
@commercetools-test-data/order Patch
@commercetools-test-data/quote-request Patch
@commercetools-test-data/quote Patch
@commercetools-test-data/staged-quote Patch
@commercetools-test-data/product Patch
@commercetools-test-data/standalone-price Patch
@commercetools-test-data/store Patch
@commercetools-test-data/associate-role Patch
@commercetools-test-data/attribute-group Patch
@commercetools-test-data/business-unit Patch
@commercetools-test-data/cart-discount Patch
@commercetools-test-data/category Patch
@commercetools-test-data/custom-object Patch
@commercetools-test-data/customer-group Patch
@commercetools-test-data/customer Patch
@commercetools-test-data/discount-code Patch
@commercetools-test-data/payment Patch
@commercetools-test-data/platform-limits Patch
@commercetools-test-data/product-discount Patch
@commercetools-test-data/product-projection Patch
@commercetools-test-data/product-selection Patch
@commercetools-test-data/product-type Patch
@commercetools-test-data/review Patch
@commercetools-test-data/shipping-method Patch
@commercetools-test-data/shopping-list Patch
@commercetools-test-data/state Patch
@commercetools-test-data/tax-category Patch
@commercetools-test-data/type Patch
@commercetools-test-data/zone Patch
@commercetools-test-data/core Patch
@commercetools-test-data/project Patch
@commercetools-test-data/utils Patch
@commercetools-test-data/generators Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@ByronDWall ByronDWall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes sure look like changes to me

@jaikamat jaikamat merged commit a83c452 into main Dec 20, 2024
4 checks passed
@jaikamat jaikamat deleted the FCT-introspected-types branch December 20, 2024 16:42
@ct-changesets ct-changesets bot mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants