Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate cart model #743

Merged
merged 16 commits into from
Jan 28, 2025
Merged

chore: migrate cart model #743

merged 16 commits into from
Jan 28, 2025

Conversation

YahiaElTai
Copy link
Contributor

This PR migrates the cart model to the new structure while maintaining the compatibility layer.

@YahiaElTai YahiaElTai requested a review from a team as a code owner January 17, 2025 12:12
@YahiaElTai YahiaElTai self-assigned this Jan 17, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: a1b655a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@YahiaElTai YahiaElTai marked this pull request as draft January 17, 2025 12:21
CarlosCortizasCT
CarlosCortizasCT reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments as a first review.

models/cart/src/cart/index.ts Outdated Show resolved Hide resolved
models/cart/src/cart/builder.ts Outdated Show resolved Hide resolved
models/cart/src/cart/fields-config.ts Show resolved Hide resolved
models/cart/src/cart/builder.spec.ts Outdated Show resolved Hide resolved
CarlosCortizasCT
CarlosCortizasCT reviewed Jan 20, 2025
View reviewed changes
models/cart/src/cart/builder.spec.ts Outdated Show resolved Hide resolved
models/cart/src/cart/builder.spec.ts Outdated Show resolved Hide resolved
models/cart/src/cart/builder.spec.ts Outdated Show resolved Hide resolved
models/cart/src/cart/fields-config.ts Outdated Show resolved Hide resolved
@YahiaElTai
Copy link
Contributor Author

YahiaElTai commented Jan 22, 2025 •
edited
Loading

I migrated all the presets and their spec files.
sample-data-fashion/ presets I migrated them manually since they are not part of the test-data-generation script.

cc @CarlosCortizasCT

@YahiaElTai YahiaElTai marked this pull request as ready for review January 22, 2025 12:20
CarlosCortizasCT
CarlosCortizasCT approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go from my side 🚀

Thanks a lot for the efforts, Yahia 🙇

@YahiaElTai
chore: migrate cart model
450218c
@YahiaElTai
chore: migrate a few more models and add tests
667d0aa
@YahiaElTai
chore: update cart model
3bb2eec
@YahiaElTai
chore: switch to key reference for rest in business unit and store fo…
17d395e 
…r the cart model
@YahiaElTai
chore: update tests to reflect new mode;
97aadc2
@YahiaElTai
chore: update tests for cart draft
c437b3f
@YahiaElTai
chore: rename spec files to builders
b707a61
@YahiaElTai
chore: remove unneeded fields from spec and fields-config
84f512b
@YahiaElTai
chore: import packages correctly by adding them to package.json
700044e
@YahiaElTai
chore: import packages correctly by adding them to package.json
8532ea5
@YahiaElTai
chore: migrate cart draft presets
dd739aa
@YahiaElTai
chore: change the export location of cart draft
1b81555
@YahiaElTai
chore: test one file
5290b1e
@YahiaElTai
chore: regenerate presets again after correcting the generator
1d7e880
@YahiaElTai
chore: correct the imports and exports of the cart model
7c9fbd2
@YahiaElTai YahiaElTai removed the request for review from a team January 28, 2025 08:38
@YahiaElTai YahiaElTai merged commit 39c1b11 into main Jan 28, 2025
3 checks passed
@YahiaElTai YahiaElTai deleted the yt-migrate-cart branch January 28, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosCortizasCT CarlosCortizasCT CarlosCortizasCT approved these changes

Assignees

@YahiaElTai YahiaElTai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YahiaElTai @CarlosCortizasCT