FCT 1079 - filters Chip
#2937
FCT 1079 - filters Chip
#2937
Conversation
ByronDWall
requested review from
stephsprinkle,
jaikamat,
ddouglasz,
tylermorrisford and
misama-ct
and removed request for
a team
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@ByronDWall thanks! I just realized we introduced |
|
and one more tiny thing. In the designs the overall height is 24px, in the PR it's 22 |
| return ( | ||
| <> | ||
| <div>{props.label}</div> | ||
| <ul style={{ display: 'flex', gap: '8px' }}> |
There was a problem hiding this comment.
Do you think we should use spacing20 here?
| <ul style={{ display: 'flex', gap: '8px' }}> | |
| <ul style={{ display: 'flex', gap: designTokens.spacing20 }}> |
There was a problem hiding this comment.
sure, but jsyk, this code is meant to be temporary
| color: ${designTokens.colorPrimary20}; | ||
| background-color: ${designTokens.colorPrimary95}; | ||
| padding: 0 ${designTokens.spacing20}; | ||
| border-radius: calc( |
|
@FilPob how do you feel about using
while |
ByronDWall
force-pushed
the
FCT-1078-chip
branch
from
dea9379 to
3f5ed31
Compare
|
@ByronDWall yeah lets do that! thanks |
|
@FilPob height and colors should now be as specified, thx! |
…reviewers can see component in preview storybook
ByronDWall
force-pushed
the
FCT-1078-chip
branch
from
9c6c9cf to
aa7adc2
Compare
This PR implements the
Chipcomponent with necessary styles and state as specified in figma.The
Chipis implemented as anli, and should be used as a child of aulcomponent, as it is meant to list the selected filter values in aFilterMenu.Component Enhancements:
labelandisDisabledprops, and styled using@commercetools-uikit/design-systemand@emotion/react.Chipcomponent to check for thelabelprop and role attribute.PLEASE NOTE: The Filters storybook must be updated to have a local-dev tag before merging this PR to main so that the Filters docs do not get published to the prod site, these docs are published for this PR as a courtesy to the reviewers.
Chip can be seen here