Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable NorfairKing packages #7137

Merged

Conversation

NorfairKing
Copy link
Contributor

Checklist:

  • Meaningful commit message, eg add my-cool-package (please don't mention build-constraints.yml)
  • At least 30 minutes have passed since uploading to Hackage
  • If applicable, required system libraries are added to 02-apt-get-install.sh or 03-custom-install.sh
  • (optional) Package is compatible with the latest version of all dependencies (Run cabal update && cabal outdated)
  • (optional) Package have been verified to work with the latest nightly snapshot, e.g by running the verify-package script

The script runs virtually the following commands in a clean directory:

  stack unpack $package-$version # `-$version` is optional
  cd $package-$version
  rm -f stack.yaml && stack init --resolver nightly --ignore-subdirs
  stack build --resolver nightly --haddock --test --bench --no-run-benchmarks

@NorfairKing NorfairKing force-pushed the reenable-NorfairKing branch 2 times, most recently from 371ec79 to c9a0fd5 Compare October 4, 2023 20:22
@NorfairKing
Copy link
Contributor Author

@juhp ready for review.

@NorfairKing NorfairKing force-pushed the reenable-NorfairKing branch from 0c95733 to f5fcf81 Compare October 4, 2023 21:22
@NorfairKing NorfairKing force-pushed the reenable-NorfairKing branch from f5fcf81 to d370686 Compare October 5, 2023 11:32
@NorfairKing
Copy link
Contributor Author

@juhp Ping, I would like these in before nixos cuts a release.

@jkachmar jkachmar merged commit 2134386 into commercialhaskell:master Oct 6, 2023
1 check passed
@NorfairKing
Copy link
Contributor Author

@jkachmar thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants