Electoral data vis upgrades #206
Conversation
commonknowledge-bot
temporarily deployed
to
electoral-displays - meep-intelligence-hub-backend PR #206
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
electoral-displays - meep-intelligence-hub-frontend PR #206
Render
Destroyed
commonknowledge-bot
had a problem deploying
to
electoral-displays - meep-intelligence-hub-worker PR #206
Render
Failure
commonknowledge-bot
had a problem deploying
to
electoral-displays - meep-intelligence-hub-worker PR #206
Render
Failure
|
|
||
| // Get min and max counts | ||
| let minCount = min(dataByBoundary.map((d) => d.count || 0)) || 0 | ||
| let minCount = 0 // min(dataByBoundary.map((d) => d.count || 0)) || 0 |
There was a problem hiding this comment.
Think so. We could make it an option to 'go from 0 or go from min' but I think in general, data we're loading is things like population, votes, £, etc — all continuous data which benefits from starting at 0. Otherwise the choropleth becomes hypersensitive to small differences between 95 and 98 or something.
The toggle is probably the most versatile approach.
| @@ -203,12 +235,12 @@ const PoliticalChoropleths: React.FC<PoliticalChoroplethsProps> = ({ | |||
| maxzoom={tileset.maxZoom} | |||
| /> | |||
|
|
|||
| <Layer | |||
| {/* <Layer | |||
| // (boundary) => boundary.boundaryType === boundaryType | ||
| // )?.tilesets | ||
|
|
||
| // const activeTileset = useActiveTileset(boundaryType) |
There was a problem hiding this comment.
suggestion: remove this if not required
| @@ -906,7 +1230,7 @@ function BigRecord({ | |||
| } | |||
|
|
|||
| const { primary, secondary } = getListValuesBasedOnDataType(item, dataType) | |||
| const isActive = explorer.isValidEntity(explorer.state) | |||
| // const isActive = explorer.isValidEntity(explorer.state) | |||
There was a problem hiding this comment.
suggestion: remove this if not required
| @@ -699,65 +868,140 @@ function RelatedDataCarousel({ data }: { data: AreaLayerDataQuery['data'] }) { | |||
| ) | |||
| } | |||
|
|
|||
| // const ELECTION_RESULTS = gql` | |||
There was a problem hiding this comment.
suggestion: remove this if not required
| ), # Back to start to close polygon | ||
| ) | ||
| bbox = Polygon(bbox_coords, srid=4326) | ||
| # areas = models.Area.objects.filter(**area_type_filter.query_filter).filter( |
There was a problem hiding this comment.
question: should the filter by combined area be removed?
It was there because when "rolling up" data to larger areas, not all of the relevant points are in the map_bounds box.
E.G. If have data at the output_area level, and I'm browsing at the LSOA level, not all the output_areas for the LSOA I'm looking at will be in the bounding box.
commonknowledge-bot
had a problem deploying
to
electoral-displays - meep-intelligence-hub-worker PR #206
Render
Failure
commonknowledge-bot
temporarily deployed
to
electoral-displays - meep-intelligence-hub-frontend PR #206
Render
Destroyed
joaquimds
force-pushed
the
electoral-displays
branch
from
2588f26 to
c96f167
Compare
commonknowledge-bot
temporarily deployed
to
electoral-displays - meep-intelligence-hub-frontend PR #206
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
electoral-displays - meep-intelligence-hub-backend PR #206
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
electoral-displays - meep-intelligence-hub-worker PR #206
Render
Destroyed
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
No description provided.