Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: querying and displaying choropleth data when filtering by map bounds #207

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

joaquimds
Copy link

Data fetching was broken when viewing a boundary type that filters data by map bounds when zoomed in.

@commonknowledge-bot commonknowledge-bot deployed to fix/advanced-choro-map-bounds - meep-database PR #207 February 4, 2025 12:24 — with Render Active
@commonknowledge-bot commonknowledge-bot temporarily deployed to fix/advanced-choro-map-bounds - meep-intelligence-hub-backend PR #207 February 4, 2025 12:24 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to fix/advanced-choro-map-bounds - meep-intelligence-hub-backend PR #207 February 4, 2025 12:25 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to fix/advanced-choro-map-bounds - meep-intelligence-hub-frontend PR #207 February 4, 2025 12:25 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to fix/advanced-choro-map-bounds - meep-intelligence-hub-worker PR #207 February 4, 2025 12:25 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to fix/advanced-choro-map-bounds - meep-intelligence-hub-backend PR #207 February 4, 2025 12:25 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to fix/advanced-choro-map-bounds - meep-intelligence-hub-frontend PR #207 February 4, 2025 12:25 — with Render Destroyed
@joaquimds joaquimds force-pushed the fix/advanced-choro-map-bounds branch from 95bc5b3 to bb596c0 Compare February 4, 2025 12:26
@commonknowledge-bot commonknowledge-bot deployed to fix/advanced-choro-map-bounds - meep-intelligence-hub-worker PR #207 February 4, 2025 12:26 — with Render Active
Copy link
Member

@janbaykara janbaykara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Just one optional comment.

hub/graphql/types/model_types.py Outdated Show resolved Hide resolved
@joaquimds joaquimds force-pushed the fix/advanced-choro-map-bounds branch from bb596c0 to 97c5b9e Compare February 5, 2025 11:20
@commonknowledge-bot commonknowledge-bot temporarily deployed to fix/advanced-choro-map-bounds - meep-intelligence-hub-backend PR #207 February 5, 2025 11:20 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to fix/advanced-choro-map-bounds - meep-intelligence-hub-frontend PR #207 February 5, 2025 11:20 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to fix/advanced-choro-map-bounds - meep-intelligence-hub-worker PR #207 February 5, 2025 11:20 — with Render Destroyed
@joaquimds joaquimds merged commit 331a448 into main Feb 5, 2025
4 checks passed
@joaquimds joaquimds deleted the fix/advanced-choro-map-bounds branch February 5, 2025 13:13
Copy link

sentry-io bot commented Feb 6, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ GraphQLError: could not convert string to float: '71.10%' /graphql View Issue
  • ‼️ GraphQLError: unknown type object /graphql View Issue
  • ‼️ GraphQLError: name 'BACKTICK_QUOTED_STRING_Percentage_registered' is not defined /graphql View Issue
  • ‼️ GraphQLError: No objects to concatenate /graphql View Issue
  • ‼️ GraphQLError: 'EU Citizens - Total electors (includes attainers) 1 December 2022' /graphql View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants