forked from mysociety/local-intelligence-hub
-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate everything to the new statistics API / choropleth UX smoothing #213
Merged
joaquimds
merged 24 commits into
main
from
feature/map-1005-migrate-over-to-new-statistics-api
Feb 10, 2025
Merged
Migrate everything to the new statistics API / choropleth UX smoothing #213
joaquimds
merged 24 commits into
main
from
feature/map-1005-migrate-over-to-new-statistics-api
Feb 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquimds
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks Jan 👍
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From a user perspective, this PR makes configuring choropleths more self-evident, and less janky/buggy/gotcha'd.
The three standard modes (count, field and formula) are complemented by a fourth: "advanced", which opens up a popup for you to edit the more complicated and fanciful options we've added recently.
Backend
In the backend, there's been a bit of refactoring. The map and explorer now always uses the same statistical maths and querying logic:
choroplethDataForSource
andgenericDataSummaryFromSourceAboutArea
resolvers and moved everything to the new statistics method (resolved bystatistics
andstatisticsForChoropleth
).filter_generic_data_using_gss_code
function.first
,second
) intoadd_computed_columns
.How Can It Be Tested?
Nominal
data type, then shade by\
Winner (2024)`(including the backticks), and enable
Are these electoral parties?`: you should see a party winner map!