build: permit incremental linking on Windows #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added with the very first commit that introduced CMake. There was no explanation for the incremental linking not being enabled. If this is a personal preference, the user can specify the flag via `-D CMAKE_SHARED_LINKER_FLAGS`. Although incremental linking does introduce padding in the binary for incremental links, that should not matter for release mode builds in theory as `/OPT:REF` and `/OPT:ICF` will trigger full links [1], which is the default in release mode. [1] https://learn.microsoft.com/en-us/cpp/build/reference/incremental-link-incrementally?view=msvc-170
|
I have no idea why that is there. (I only half understand CMake anyway; I think someone else contributed the orginal CMake build.) Will leave this open for a bit in case anyone remembers. @nwellnhof ? |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added with the very first commit that introduced CMake. There was no explanation for the incremental linking not being enabled. If this is a personal preference, the user can specify the flag via
-D CMAKE_SHARED_LINKER_FLAGS. Although incremental linking does introduce padding in the binary for incremental links, that should not matter for release mode builds in theory as/OPT:REFand/OPT:ICFwill trigger full links [1], which is the default in release mode.[1] https://learn.microsoft.com/en-us/cpp/build/reference/incremental-link-incrementally?view=msvc-170