feat(pallets/subspace): update parameters of proposals and remove set…

…_floor_founder_share
commune-ai · May 3, 2024 · 6213c2f · 6213c2f
1 parent 5c49ff6
commit 6213c2f
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 14 deletions.
diff --git a/pallets/subspace/src/global.rs b/pallets/subspace/src/global.rs
@@ -93,10 +93,7 @@ impl<T: Config> Pallet<T> {
         );
 
         // Make sure of floor founder share
-        ensure!(
-            floor_founder_share >= params.founder_share,
-            Error::<T>::InvalidFounderShare
-        );
+        ensure!(floor_founder_share >= 8, Error::<T>::InvalidFounderShare);
 
         // Make sure that the burn rate is below 100%
         ensure!(params.burn_rate <= 100, Error::<T>::InvalidBurnRate);
@@ -325,10 +322,6 @@ impl<T: Config> Pallet<T> {
         AdjustmentAlpha::<T>::put(adjustment_alpha);
     }
 
-    pub fn set_floor_founder_share(founder_share: u8) {
-        FloorFounderShare::<T>::put(founder_share);
-    }
-
     // Whitelist management
     pub fn is_in_legit_whitelist(account_id: &T::AccountId) -> bool {
         LegitWhitelist::<T>::contains_key(account_id)

diff --git a/pallets/subspace/tests/profit_share.rs b/pallets/subspace/tests/profit_share.rs
@@ -3,6 +3,7 @@ mod mock;
 use frame_support::assert_ok;
 use log::info;
 use mock::*;
+use pallet_subspace::FloorFounderShare;
 use sp_core::U256;
 use sp_std::vec;
 
@@ -15,7 +16,7 @@ fn test_add_profit_share() {
         let voter_key = U256::from(1);
         // make sure that the results won´t get affected by burn
         SubspaceModule::set_min_burn(0);
-        SubspaceModule::set_floor_founder_share(0);
+        FloorFounderShare::put(0);
 
         register_module(netuid, miner_key, 1_000_000_000).expect("register miner module failed");
         register_module(netuid, voter_key, 1_000_000_000).expect("register voter module failed");

diff --git a/pallets/subspace/tests/step_yuma.rs b/pallets/subspace/tests/step_yuma.rs
@@ -1,6 +1,9 @@
 use crate::mock::*;
 use frame_support::assert_ok;
-use pallet_subspace::yuma::{AccountKey, EmissionMap, ModuleKey, YumaCalc};
+use pallet_subspace::{
+    yuma::{AccountKey, EmissionMap, ModuleKey, YumaCalc},
+    FloorFounderShare,
+};
 use sp_core::U256;
 use std::collections::BTreeMap;
 mod mock;
@@ -44,7 +47,7 @@ fn test_1_graph() {
     new_test_ext().execute_with(|| {
         SubspaceModule::set_unit_emission(23148148148);
         SubspaceModule::set_min_burn(0);
-        SubspaceModule::set_floor_founder_share(0);
+        FloorFounderShare::put(0);
 
         // Register general subnet
         assert_ok!(register_module(0, 10.into(), 1));
@@ -115,7 +118,7 @@ fn test_10_graph() {
     new_test_ext().execute_with(|| {
         SubspaceModule::set_unit_emission(23148148148);
         SubspaceModule::set_min_burn(0);
-        SubspaceModule::set_floor_founder_share(0);
+        FloorFounderShare::put(0);
         SubspaceModule::set_max_registrations_per_block(1000);
         // Register general subnet
         assert_ok!(register_module(0, 10_000.into(), 1));

diff --git a/pallets/subspace/tests/weights.rs b/pallets/subspace/tests/weights.rs
@@ -1,7 +1,7 @@
 mod mock;
 use frame_support::{assert_err, assert_ok};
 
-use pallet_subspace::Error;
+use pallet_subspace::{Error, FloorFounderShare};
 use sp_core::U256;
 use sp_runtime::DispatchError;
 
@@ -267,7 +267,7 @@ fn test_weight_age() {
         const PASSIVE_VOTER: u16 = 0;
         const ACTIVE_VOTER: u16 = 1;
         SubspaceModule::set_max_registrations_per_block(1000);
-        SubspaceModule::set_floor_founder_share(0);
+        FloorFounderShare::put(0);
 
         // Register modules
         (0..MODULE_COUNT).for_each(|i| {