Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow service name redefine for OTL #56

Merged
merged 1 commit into from
Dec 11, 2024
Merged

allow service name redefine for OTL #56

merged 1 commit into from
Dec 11, 2024

Conversation

lesnik512
Copy link
Contributor

@lesnik512 lesnik512 commented Dec 11, 2024 •
edited
Loading

We need this, because we have service name with some prefix, specific for opentelemetry

@lesnik512 lesnik512 requested review from insani7y and vrslev December 11, 2024 10:51
@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 98.78% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...obootstrap/instruments/opentelemetry_instrument.py 100.00% <100.00%> (ø)

@lesnik512 lesnik512 merged commit 20c1d5a into main Dec 11, 2024
15 checks passed
@lesnik512 lesnik512 deleted the allow-custom-service-name-otl branch December 11, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insani7y insani7y Awaiting requested review from insani7y

@vrslev vrslev Awaiting requested review from vrslev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lesnik512