[GitHub Actions] Introduce Shellcheck to check bash code #1018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Description
ShellCheck finds bugs in your shell scripts. It is an open source tool (https://github.com/koalaman/shellcheck) that runs analysis on your shell scripts.
As this project uses shell and bash intensively, automated checks that help humans avoid bugs may be helpful.
🛠️ Type of Change
Please check the relevant options:
✅ Prerequisites
The following steps must be completed for the pull request to be considered:
📋 Additional Information (optional)
This PR might not be mergable from the get go as shellcheck throws a lot of errors on the repository itself.
Sometimes it throws "false positives" due to the way the scripts are written.
E.g.
DISK${i}_REF
vs.DISK1_REF
:--
A full list of error codes and descriptions can be found here: https://www.shellcheck.net/wiki/
Those can be disables via