Update MOTD dynamically #1267
Closed
Update MOTD dynamically #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MickLesk
reviewed
Jan 5, 2025
| # Get the current private IP address | ||
| IP=$(hostname -I | awk '{print $1}') # Private IP | ||
| # Create our dynamic MOTD script | ||
| MOTD_FILE="/etc/update-motd.d/01-proxmox-tteck" |
There was a problem hiding this comment.
Well no reason TBH, just to maintain legacy and maybe an indication that this file was made by the script. Let me know if you prefer other name.
|
Whats the Change ? |
I'm sorry if it's not clear enough. I modify the script to, instead creating static MOTD, it will create a dynamic MOTD script file. This is particularly useful to reflect IP changes, like if you set DHCP static mappings for the new LXC/VM after creating them. |
|
Duplicate of #1216 and also misses alpine-install.func |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Description
This PR modifies the default
install.func(debian/ubuntu) to implement a dynamic Message of the Day (MOTD) replacing the static one.🛠️ Type of Change
Please check the relevant options:
✅ Prerequisites
The following steps must be completed for the pull request to be considered:
📋 Additional Information
I have modified the alpine one (
alpine-install.func), but waiting for this PR if needed or not.