Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: AdventureLog: unzip to /opt/ #1370

Conversation

JesperDramsch
Copy link
Contributor

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.


✍️ Description

Follows the directive of @michelroegl-brunner to process everything in /opt/ and fixes the bug reported in #1334


Please remove unneeded lines!


🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

@JesperDramsch JesperDramsch requested a review from a team as a code owner January 9, 2025 21:50
@github-actions github-actions bot added the update script A change that updates a script label Jan 9, 2025
@JesperDramsch JesperDramsch changed the title fix: unzip to /opt/ fix(adventurelog): unzip to /opt/ Jan 9, 2025
@MickLesk MickLesk changed the title fix(adventurelog): unzip to /opt/ Fix: AdventureLog: unzip to /opt/ Jan 9, 2025
@MickLesk MickLesk merged commit d8f433c into community-scripts:main Jan 9, 2025
5 checks passed
@JesperDramsch
Copy link
Contributor Author

Saw the discussion by @Solear in #1334. This is tested on my system.

As for @Aloe-recite you will still have to adjust the /opt/AdventureLog_version.txt to contain 0.7.1 so the script runs.

@Aloe-recite
Copy link

Thanks, outstanding job! It’s wonderful to see how this community is thriving!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants