Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] build.func&install.func: Fix ssh keynot added error #1502

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

dsiebel
Copy link
Contributor

@dsiebel dsiebel commented Jan 15, 2025

✍️ Description

A PR I created for develop was recently cherry-picked into main (#1456), but it only contained one half of the changes.
The SSH key that can be specified during advanced setup was not being added to the container.
This PR addresses that, recovering the changes made in the original PR.


🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

When creating the original PR, I was also pondering the idea of skipping the part that replaces

PermitRootLogin prohibit-password`

with

PermitRootLogin yes

in the sshd config, when a root password has been set.
What do you think, would this be a worthy improvement?

@dsiebel dsiebel requested a review from a team as a code owner January 15, 2025 12:09
@github-actions github-actions bot added the high risk A change that can affect many scripts label Jan 15, 2025
@michelroegl-brunner michelroegl-brunner changed the title fix: actually add the given root SSH key to the container [core] build.func&install.func: Fix ssh keynot added error Jan 15, 2025
@michelroegl-brunner michelroegl-brunner added the maintenance Code maintenance or general upkeep of the project label Jan 15, 2025
@MickLesk MickLesk merged commit 2aed45f into community-scripts:main Jan 15, 2025
4 checks passed
@dsiebel dsiebel deleted the fix-root-ssh-key-install branch January 17, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high risk A change that can affect many scripts maintenance Code maintenance or general upkeep of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants