[github]: add new Frontend_Report / Issue_Report & optimize config.yml #226

MickLesk · 2024-11-13T15:55:02Z

Description

Add new Frontend_Report for Website
Optimize Issue Report
Optimize Issue Overview

Old:

New:

Type of change

Please check the relevant option(s):

Bug fix (non-breaking change that resolves an issue)
New feature (non-breaking change that adds functionality)
Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
Testing performed (I have tested my changes, ensuring everything works as expected)
Documentation updated (I have updated any relevant documentation)

remz1337 · 2024-11-13T16:59:48Z

Not sure about the documentation one. I checked the link the PR and it redirects to frontend issue?

MickLesk · 2024-11-13T17:02:40Z

Not sure about the documentation one. I checked the link the PR and it redirects to frontend issue?

This is currently intended because the general documentation for LXCs/VMs and other scripts can be found on the website. (CPU/RAM/login etc )

havardthom

Have some comments, but eating dinner atm, will add after

MickLesk · 2024-11-13T19:22:03Z

Have some comments, but eating dinner atm, will add after

Take your time, I'm out for today :-) If then I'll take a look at it tomorrow.

havardthom

Quite a few comments here, honestly I just think I like the old templates better. This adds a lot and feels a little bloated to me. In my eyes we have two things which are user-facing: the scripts and a website. Having one template for each feels simpler and more consistent for me.

.github/ISSUE_TEMPLATE/bug_report.yml

.github/ISSUE_TEMPLATE/frontend_report.yml

remz1337 · 2024-11-13T21:15:31Z

Really great review @havardthom, I agree with everything

MickLesk · 2024-11-13T21:22:21Z

I absolutely do not agree with every comment. Some comments are also in the existing template from tteck. Somehow it seems like I'm being portrayed as more stupid ^^

About the wording, okay but you don't have to optimize every single sentence. It's already hard "educating", like a teacher. But as far as I'm concerned, I can look through it tomorrow.

remz1337 · 2024-11-13T21:43:49Z

@MickLesk please don't take this personally. I think you have been doing an excellent job as maintainer so far, don't downplay yourself.

Me agreeing with his review doesn't mean I'm right either ;) I'm just providing my thoughts. This project now being community driven means we may need more time to come to an agreement. Would be great to hear from other contributors too (@community-scripts/contributor)

havardthom · 2024-11-13T22:09:25Z

@MickLesk I'm sorry if I come off as harsh, I'm just voicing my opinions and it is fine to disregard them if people disagree. I do a lot of nitpicking but I feel it is important to keep the consistency and simplicity tteck lived by.
I absolutely don't think or want to portray you as stupid, I think you do great work for the community and I really appreciate all of it, as I'm sure the rest of the team also does.

Mellowlynx · 2024-11-13T22:36:08Z

@MickLesk I could not agree more with @havardthom last message.
The consistency and simplicity tteck used is indeed important, and it can be nice to have someone who is nitpicking.
As it shows's respect and real thought about the subject. (most of the time)
We all see points different, but let's use the feedback to improve overall and try to see someone else's perspective.

Mellowlynx · 2024-11-13T22:37:08Z

As it's getting late, I will be happy to also check and check the feedback sometime tomorrow.

switch general to other Co-authored-by: Håvard Gjøby Thom <[email protected]>

remove title Co-authored-by: Håvard Gjøby Thom <[email protected]>

remove label Co-authored-by: Håvard Gjøby Thom <[email protected]>

update text for questions and help Co-authored-by: Håvard Gjøby Thom <[email protected]>

harmonize with readme (discord) Co-authored-by: Håvard Gjøby Thom <[email protected]>

harmonize title for Frontend Co-authored-by: Håvard Gjøby Thom <[email protected]>

harmonize text Co-authored-by: Håvard Gjøby Thom <[email protected]>

update label Co-authored-by: Håvard Gjøby Thom <[email protected]>

remove title Co-authored-by: Håvard Gjøby Thom <[email protected]>

MickLesk · 2024-11-19T08:23:05Z

So ive updated smart little things.
I think it looks good, is clearly laid out and contains the most important functions.
The only thing that could be made smarter is the text under the title of the issue report.

Feedback on this is welcome!

You can test it here:
https://github.com/MickLesk/Proxmox_DEV/issues/new/choose

@BramSuurdje
Especially for you, you will “work” the most with it (Frontend-Report). Is the front-end report good, or is it missing something, or is it too much?

havardthom

Looks good, thank you for improving

Add new Frontend_Report / Issue_Report & optimize config.yml

4f5f383

MickLesk requested a review from a team as a code owner November 13, 2024 15:55

BramSuurdje previously approved these changes Nov 13, 2024

View reviewed changes

havardthom reviewed Nov 13, 2024

View reviewed changes

MickLesk added documentation A change to documentation enhancement New feature or request nice to have A change that is a nice to have labels Nov 13, 2024

Update .github/ISSUE_TEMPLATE/bug_report.yml

3d7c8b6

switch general to other Co-authored-by: Håvard Gjøby Thom <[email protected]>

MickLesk dismissed BramSuurdje’s stale review via 3d7c8b6 November 14, 2024 08:10

MickLesk and others added 11 commits November 14, 2024 09:10

Update .github/ISSUE_TEMPLATE/bug_report.yml

082fe48

remove title Co-authored-by: Håvard Gjøby Thom <[email protected]>

Update .github/ISSUE_TEMPLATE/bug_report.yml

87aceb8

remove label Co-authored-by: Håvard Gjøby Thom <[email protected]>

Update .github/ISSUE_TEMPLATE/config.yml

394d09f

update text for questions and help Co-authored-by: Håvard Gjøby Thom <[email protected]>

Update .github/ISSUE_TEMPLATE/config.yml

7ff1626

harmonize with readme (discord) Co-authored-by: Håvard Gjøby Thom <[email protected]>

Update .github/ISSUE_TEMPLATE/frontend_report.yml

363f6fb

harmonize title for Frontend Co-authored-by: Håvard Gjøby Thom <[email protected]>

remove documentation issue

65a8fb7

Update .github/ISSUE_TEMPLATE/config.yml

eef3ef7

harmonize text Co-authored-by: Håvard Gjøby Thom <[email protected]>

Update .github/ISSUE_TEMPLATE/frontend_report.yml

7375c5b

update label Co-authored-by: Håvard Gjøby Thom <[email protected]>

Update .github/ISSUE_TEMPLATE/frontend_report.yml

0d5c21c

remove title Co-authored-by: Håvard Gjøby Thom <[email protected]>

Harmonize Frontend > Website

870f6d8

remove "frontend" word

6bfe5d0

github-actions bot added the maintenance Code maintenance or general upkeep of the project label Nov 19, 2024

Add "Other" to Frontend-Report

6f4e90e

MickLesk requested review from havardthom, Mellowlynx and BramSuurdje November 19, 2024 09:55

MickLesk self-assigned this Nov 19, 2024

MickLesk removed the nice to have A change that is a nice to have label Nov 19, 2024

BramSuurdje approved these changes Nov 19, 2024

View reviewed changes

havardthom approved these changes Nov 19, 2024

View reviewed changes

MickLesk removed the request for review from Mellowlynx November 19, 2024 18:04

MickLesk merged commit 9148ea1 into main Nov 19, 2024
3 checks passed

MickLesk deleted the MickLesk_Dev branch November 19, 2024 20:38

community-scripts locked and limited conversation to collaborators Nov 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[github]: add new Frontend_Report / Issue_Report & optimize config.yml #226

[github]: add new Frontend_Report / Issue_Report & optimize config.yml #226

MickLesk commented Nov 13, 2024

remz1337 commented Nov 13, 2024

MickLesk commented Nov 13, 2024

havardthom left a comment

MickLesk commented Nov 13, 2024

havardthom left a comment

remz1337 commented Nov 13, 2024

MickLesk commented Nov 13, 2024

remz1337 commented Nov 13, 2024

havardthom commented Nov 13, 2024

Mellowlynx commented Nov 13, 2024

Mellowlynx commented Nov 13, 2024

MickLesk commented Nov 19, 2024 •

edited

Loading

havardthom left a comment

[github]: add new Frontend_Report / Issue_Report & optimize config.yml #226

[github]: add new Frontend_Report / Issue_Report & optimize config.yml #226

Conversation

MickLesk commented Nov 13, 2024

Description

Type of change

Prerequisites

remz1337 commented Nov 13, 2024

MickLesk commented Nov 13, 2024

havardthom left a comment

Choose a reason for hiding this comment

MickLesk commented Nov 13, 2024

havardthom left a comment

Choose a reason for hiding this comment

remz1337 commented Nov 13, 2024

MickLesk commented Nov 13, 2024

remz1337 commented Nov 13, 2024

havardthom commented Nov 13, 2024

Mellowlynx commented Nov 13, 2024

Mellowlynx commented Nov 13, 2024

MickLesk commented Nov 19, 2024 • edited Loading

havardthom left a comment

Choose a reason for hiding this comment

MickLesk commented Nov 19, 2024 •

edited

Loading