-
-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Option "check_storage" and "check_container_ressources" #249
Conversation
And yes, I think the icons are better than the Ascii X and Check-Mark characters. 😄 Every terminal/console has supported them for several years. I will also bring it up to date in the next merges (the rest). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea and nice utility functions, will make scripts much cleaner
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
This is a great improvement. |
- remove locals - use var_variables - show storage in percent - harmonize some texts - optimize Prompt (Continue anyway)
Description
1. added new function:
check_storage
=> This message already appears in some LXCs and has now been adopted as a basic function in build.func.
This can be added in the function update_script() area. (ct/lxc.sh).
It should be added subsequently for all CTs.
https://github.com/MickLesk/Proxmox_DEV/blob/06ad30d94cc82cd793d6ac4cbcf1077a1e2f5994/ct/nextpvr.sh#L57
2. added new function:
check_container_ressources
=> if the ressources are not enough based on ct/script.sh the script exit with an output.
=> This message only appears if the RAM < var_ram or the cores < var_cpu of the CT
This can be added in the function update_script() area. (ct/lxc.sh).
It should be added subsequently for all CTs.
https://github.com/MickLesk/Proxmox_DEV/blob/06ad30d94cc82cd793d6ac4cbcf1077a1e2f5994/ct/nextpvr.sh#L58
3. GENERAL:
The ct\lxc.sh scripts should now always look like this in the update area (keyword: harmonization)
Type of change
Please check the relevant option(s):
Prerequisites
The following efforts must be made for the PR to be considered. Please check when completed:
Based to this issue:
#236