Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RomM #257

Closed
wants to merge 2 commits into from
Closed

Conversation

SavageCore
Copy link

Description

I see in your note you don't often merge gaming scripts, that's a shame. Oh well the work is done now.

Add installer for RomM.

Originally requested here and here.

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

@SavageCore SavageCore requested a review from a team as a code owner November 14, 2024 22:22
@github-actions github-actions bot added new script A change that adds a new script documentation A change to documentation high risk A change that can affect many scripts labels Nov 14, 2024
@newzealandpaul
Copy link
Contributor

@SavageCore thank you for taking the time to write this script. The policy so far as been to not accept gaming scripts (I personally do not know what the reason is, other than it was tteck's policy which we are not changing at this point in time).

A problem with the script is that it wraps docker. It certainly makes installation earlier, but the main point of this project is to create LXCs offering an alternative to docker. The solution we offer is a docker LXC, where people can use docker if they need to.

For these reasons I am going to close this PR.

I don't want to discourage you, having read the code I know you put a lot of time and care into this script. I hope you will considering submitting a non-docker script in the future. Leave this branch on your repo and we can discuss on discord doing another PR in the future.

@MickLesk
Copy link
Member

Hi,

a short feedback from me.

  1. tteck never wanted to have gaming scripts
  2. we have currently continued to do so, as these also have to be maintained. I'm not a gamer myself, I turn on my PS5 once a quarter and enjoy it :-D That makes it difficult, of course.
  3. we only support bare-metal installations (with the exception of docker lxc and dockge lxc), i.e. pure installations without docker wrap.

=> It would be worth considering, but we have to discuss internally whether something like this could be interesting for Dockge, or how we will deal with gaming scripts in the future.

@DarkHollow
Copy link

How can I use this script on my Proxmox?

@MickLesk
Copy link
Member

How can I use this script on my Proxmox?

Use docker LXC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation A change to documentation high risk A change that can affect many scripts new script A change that adds a new script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants