Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Recyclarr LXC #271

Merged
merged 5 commits into from
Nov 16, 2024
Merged

Add Recyclarr LXC #271

merged 5 commits into from
Nov 16, 2024

Conversation

MrYadro
Copy link
Contributor

@MrYadro MrYadro commented Nov 15, 2024

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Added Recyclarr script

Recyclarr is a command-line application that will automatically synchronize recommended settings from the TRaSH guides to your Sonarr/Radarr instances.

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

More info about Recyclarr https://recyclarr.dev/wiki/

@MrYadro MrYadro requested a review from a team as a code owner November 15, 2024 21:47
@github-actions github-actions bot added new script A change that adds a new script documentation A change to documentation labels Nov 15, 2024
@MrYadro MrYadro force-pushed the recyclarr branch 3 times, most recently from 5759e2e to 9155012 Compare November 15, 2024 21:58
Copy link
Contributor

@havardthom havardthom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider if this is worthy of its own LXC or if it should rather be an optional addon to Sonarr / Radarr LXC, since it is just a CLI tool

@MrYadro
Copy link
Contributor Author

MrYadro commented Nov 15, 2024

We should consider if this is worthy of its own LXC or if it should rather be an optional addon to Sonarr / Radarr LXC, since it is just a CLI tool

That's a tough question, autobrr is kinda the same to me. Yet it has a separate LXC. At the same time I agree that it could be just an addon.

havardthom
havardthom previously approved these changes Nov 15, 2024
@MickLesk MickLesk merged commit 163cc73 into community-scripts:main Nov 16, 2024
1 check passed
@havardthom havardthom added website A change to the website and removed documentation A change to documentation labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new script A change that adds a new script website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants