Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Komga LXC #275

Merged
merged 25 commits into from
Nov 17, 2024
Merged

Add Komga LXC #275

merged 25 commits into from
Nov 17, 2024

Conversation

yry-dev
Copy link
Contributor

@yry-dev yry-dev commented Nov 16, 2024

Description

Add new script for a komga lxc. This is my first attempt at one so candid feedback is welcomed.
Komga is a media server for your comics, mangas, BDs, magazines and eBooks. Kinda like plex for ebooks and comics.

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

@yry-dev yry-dev requested a review from a team as a code owner November 16, 2024 03:17
@github-actions github-actions bot added new script A change that adds a new script documentation A change to documentation labels Nov 16, 2024
Copy link
Member

@MickLesk MickLesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkout my comments, there are some things todo 😄

@yry-dev
Copy link
Contributor Author

yry-dev commented Nov 16, 2024

Checkout my comments, there are some things todo 😄

OK I think I took care of all the change requests.

@MickLesk
Copy link
Member

MickLesk commented Nov 16, 2024

@havardthom can you take a look and give Feedback? I have made some improvements, but only from my cell phone, I think I may have overlooked or forgotten something

Edit: I think the ASCII is also wrong or? It doesn't look right on the app.

havardthom
havardthom previously approved these changes Nov 16, 2024
yry-dev and others added 8 commits November 16, 2024 21:02
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
yry-dev and others added 4 commits November 16, 2024 21:04
@havardthom havardthom merged commit f9e0dfb into community-scripts:main Nov 17, 2024
1 check passed
@havardthom havardthom added website A change to the website and removed documentation A change to documentation labels Nov 17, 2024
@yry-dev yry-dev deleted the komga-pr branch November 21, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new script A change that adds a new script website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants