Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AlertColors info style in site config for consistent dark mode appearance #279

Merged

Conversation

BramSuurdje
Copy link
Collaborator

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

This pull request includes a small change to the frontend/src/config/siteConfig.tsx file. The change modifies the info alert color configuration to adjust the order of the dark mode background and border classes.

Fixes # (issue)

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Provide any additional context or screenshots about the feature or fix here.

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

  • Related PR #

@BramSuurdje BramSuurdje requested a review from a team as a code owner November 16, 2024 09:34
Copy link
Contributor

@havardthom havardthom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing it is fine, would be nice to include a screenshot for visual changes like this :)

@havardthom havardthom merged commit d41d381 into community-scripts:main Nov 16, 2024
1 check passed
@BramSuurdje BramSuurdje deleted the fix-alert-contrast-colors branch November 16, 2024 11:35
@havardthom havardthom added website A change to the website and removed frontend labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants