Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new LXC: NextPVR #391

Merged
merged 8 commits into from
Nov 21, 2024
Merged

Add new LXC: NextPVR #391

merged 8 commits into from
Nov 21, 2024

Conversation

MickLesk
Copy link
Member

@MickLesk MickLesk commented Nov 20, 2024

Description

Add new LXC: NextPVR.
I only can test the usage of the ui. i dont have an System for it.
After Merge we can add the requester as final reviewer / or need later an bugfix.

Fixes # (issue)
Fixes #384

Type of change

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

@MickLesk MickLesk requested a review from a team as a code owner November 20, 2024 12:29
@github-actions github-actions bot added new script A change that adds a new script website A change to the website labels Nov 20, 2024
havardthom
havardthom previously approved these changes Nov 20, 2024
ct/nextpvr.sh Outdated Show resolved Hide resolved
ct/nextpvr.sh Show resolved Hide resolved
ct/nextpvr.sh Show resolved Hide resolved
ct/nextpvr.sh Outdated Show resolved Hide resolved
ct/nextpvr.sh Outdated Show resolved Hide resolved
install/nextpvr-install.sh Show resolved Hide resolved
json/nextpvr.json Outdated Show resolved Hide resolved
Co-authored-by: Håvard Gjøby Thom <[email protected]>
@MickLesk
Copy link
Member Author

@havardthom Done & Tested | Approve pending

havardthom
havardthom previously approved these changes Nov 21, 2024
Copy link
Contributor

@havardthom havardthom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are strings in all other json's. Perhaps they should be numbers, but then it should be fixed everywhere

json/nextpvr.json Outdated Show resolved Hide resolved
json/nextpvr.json Outdated Show resolved Hide resolved
json/nextpvr.json Outdated Show resolved Hide resolved
Co-authored-by: Håvard Gjøby Thom <[email protected]>
MickLesk and others added 2 commits November 21, 2024 10:06
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
@MickLesk
Copy link
Member Author

These are strings in all other json's. Perhaps they should be numbers, but then it should be fixed everywhere

I was wondering, because it doesn't actually need “[INT]” if it's just numbers? But okay, it's adjusted ^^

install/nextpvr-install.sh Show resolved Hide resolved
install/nextpvr-install.sh Show resolved Hide resolved
@newzealandpaul newzealandpaul merged commit ac67616 into main Nov 21, 2024
4 checks passed
@MickLesk MickLesk deleted the nextpvr branch November 22, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new script A change that adds a new script website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NextPVR
4 participants