Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Z-Wave JS UI script #546

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Fix Z-Wave JS UI script #546

merged 2 commits into from
Nov 28, 2024

Conversation

MickLesk
Copy link
Member

Description

An update was probably possible before, but it was programmed really badly.
I quickly reworked the whole script again.

  • Now it works with an .env file
  • Not all user data is overwritten during the update
  • Update adapted to our conventions

Fixes #207

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Tested by User, migrated in Script.

@MickLesk MickLesk requested a review from a team as a code owner November 27, 2024 15:24
@github-actions github-actions bot added update script A change that updates a script website A change to the website labels Nov 27, 2024
@havardthom havardthom changed the title Reworked Script ZWave JS UI | Add Envoirement-File Fix Z-Wave JS UI script Nov 27, 2024
@MickLesk MickLesk merged commit 1cb822b into main Nov 28, 2024
4 checks passed
@MickLesk MickLesk deleted the zwave_patch branch November 29, 2024 10:42
@schonzen
Copy link

I just finally found this breaking change that wasn't labeled as such after stumbling into the break while trying to troubleshoot a failing firmware upgrade. All I wanted was the new ZWave-JS, I didn't realize I was getting such a heavily reworked update script designed for an install script that didn't exist until this change. I'm new to this community, but really liked tteck's work.

Wouldn't it have made sense to need to write an update script that migrated to the new env method? Otherwise this is a purely breaking change for any install that existed before it.

I thought about writing an issue first but I wanted to find what happened where and found this.

@MickLesk
Copy link
Member Author

1 second search in discussions:
#635

@havardthom
Copy link
Contributor

I agree that this commit should be marked as breaking change, I will manually fix it in the changelog. Regarding update scripts handling breaking changes that applications choose to make, that is not in our scope and will make the scripts unmanageable over time.

@schonzen
Copy link

Oh, the break was from the script not the application.

@havardthom havardthom added the breaking change A change that is not backward compatible label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A change that is not backward compatible update script A change that updates a script website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zwave JS UI updated it's requirements to include ENV variables.
3 participants