Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New script: Unbound LXC #547

Merged
merged 29 commits into from
Dec 2, 2024
Merged

New script: Unbound LXC #547

merged 29 commits into from
Dec 2, 2024

Conversation

wimb0
Copy link
Contributor

@wimb0 wimb0 commented Nov 27, 2024

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

This adds Unbound DNS as a standalone LXC.

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

It is listening at port 5335 for DNS requests.

Related Pull Requests / Discussions

#530

If there are other pull requests or discussions related to this change, please link them here:

  • Related PR #

@wimb0 wimb0 requested a review from a team as a code owner November 27, 2024 15:27
@github-actions github-actions bot added the new script A change that adds a new script label Nov 27, 2024
Copy link
Member

@MickLesk MickLesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a few comments. Revise the script first, then I'll take another look. 😄

As a Big Note:
The .json for the web page is missing. You can also generate this on our website:
https://community-scripts.github.io/ProxmoxVE/json-editor

install/unbound-install.sh Outdated Show resolved Hide resolved
install/unbound-install.sh Outdated Show resolved Hide resolved
install/unbound-install.sh Show resolved Hide resolved
install/unbound-install.sh Show resolved Hide resolved
install/unbound-install.sh Outdated Show resolved Hide resolved
install/unbound-install.sh Show resolved Hide resolved
install/unbound-install.sh Show resolved Hide resolved
ct/unbound.sh Outdated Show resolved Hide resolved
@github-actions github-actions bot added the website A change to the website label Nov 27, 2024
@wimb0
Copy link
Contributor Author

wimb0 commented Nov 27, 2024

Fixed requested changes.

@wimb0 wimb0 requested a review from MickLesk November 27, 2024 16:06
@MickLesk MickLesk requested a review from havardthom November 27, 2024 16:11
@MickLesk
Copy link
Member

@havardthom I still see 3-4 things. Can you still give feedback?

havardthom
havardthom previously approved these changes Nov 28, 2024
install/unbound-install.sh Outdated Show resolved Hide resolved
install/unbound-install.sh Show resolved Hide resolved
install/unbound-install.sh Outdated Show resolved Hide resolved
install/unbound-install.sh Outdated Show resolved Hide resolved
install/unbound-install.sh Outdated Show resolved Hide resolved
install/unbound-install.sh Outdated Show resolved Hide resolved
Co-authored-by: Håvard Gjøby Thom <[email protected]>
havardthom
havardthom previously approved these changes Nov 28, 2024
install/unbound-install.sh Show resolved Hide resolved
install/unbound-install.sh Outdated Show resolved Hide resolved
install/unbound-install.sh Outdated Show resolved Hide resolved
install/unbound-install.sh Outdated Show resolved Hide resolved
install/unbound-install.sh Outdated Show resolved Hide resolved
install/unbound-install.sh Outdated Show resolved Hide resolved
install/unbound-install.sh Outdated Show resolved Hide resolved
install/unbound-install.sh Outdated Show resolved Hide resolved
json/unbound.json Outdated Show resolved Hide resolved
json/unbound.json Outdated Show resolved Hide resolved
wimb0 and others added 3 commits November 28, 2024 12:50
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
wimb0 and others added 11 commits November 28, 2024 12:53
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
@havardthom havardthom changed the title Add Unbound LXC New script: Unbound LXC Nov 28, 2024
@wimb0
Copy link
Contributor Author

wimb0 commented Nov 28, 2024

Is there a way to add some settings via the advanced install method?
Would be nice to give users a choice to set some logging and/or hardening settings via the advanced install method.

@havardthom
Copy link
Contributor

havardthom commented Nov 28, 2024

Is there a way to add some settings via the advanced install method? Would be nice to give users a choice to set some logging and/or hardening settings via the advanced install method.

Advanced settings are static, you can add yes/no prompts in install script, though i would not have to many and only if it's important. People should be able to change configuration manually in unbound.conf to their liking pretty easily.

read -r -p "Would you like to add ...? <y/N> " prompt

@wimb0
Copy link
Contributor Author

wimb0 commented Nov 30, 2024

Is there a way to add some settings via the advanced install method? Would be nice to give users a choice to set some logging and/or hardening settings via the advanced install method.

Advanced settings are static, you can add yes/no prompts in install script, though i would not have to many and only if it's important. People should be able to change configuration manually in unbound.conf to their liking pretty easily.

read -r -p "Would you like to add ...? <y/N> " prompt

Thanks for the answer. It is not really usefull to add to this then :-)

install/unbound-install.sh Show resolved Hide resolved
@MickLesk MickLesk merged commit 342e145 into community-scripts:main Dec 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new script A change that adds a new script website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants