Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New script: Mylar3 LXC #554

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Conversation

davalanche
Copy link
Contributor

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

I have created a new LXC: Mylar3.

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

  • I chose to go with a git source install (clone) vs. a git release as the former allows for application updates through the user interface.
  • The unrar install logic was copied from the SABnzbd script.

Related Pull Requests / Discussions

@davalanche davalanche requested a review from a team as a code owner November 27, 2024 21:43
@github-actions github-actions bot added new script A change that adds a new script website A change to the website labels Nov 27, 2024
@havardthom havardthom changed the title Add new LXC: Mylar3 New script: Mylar3 LXC Nov 28, 2024
ct/mylar3.sh Outdated Show resolved Hide resolved
ct/mylar3.sh Outdated Show resolved Hide resolved
install/mylar3-install.sh Outdated Show resolved Hide resolved
install/mylar3-install.sh Outdated Show resolved Hide resolved
install/mylar3-install.sh Outdated Show resolved Hide resolved
install/mylar3-install.sh Show resolved Hide resolved
install/mylar3-install.sh Show resolved Hide resolved
install/mylar3-install.sh Outdated Show resolved Hide resolved
install/mylar3-install.sh Outdated Show resolved Hide resolved
install/mylar3-install.sh Outdated Show resolved Hide resolved
davalanche and others added 3 commits November 29, 2024 16:44
The rest of the suggestions will be addressed in my local repo and pushed back

Co-authored-by: Håvard Gjøby Thom <[email protected]>
@MickLesk
Copy link
Member

Are you fine with the latest changes, @havardthom ?

@MickLesk MickLesk merged commit 85b8039 into community-scripts:main Dec 2, 2024
1 check passed
@davalanche davalanche deleted the mylar3 branch January 8, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new script A change that adds a new script website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants