-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add vitest, add json validation tests, fix broken json files #566
Conversation
2d253ca
to
e92eb47
Compare
Json files removed because they don't have scripts:
|
Fixed json files with bug in |
json editor is also customized? So that it is no longer hdd=“2”, instead hdd=2 ? |
json editor already used |
LGTM! good addition |
Note
We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.
Description
interface_port
,hdd
,cpu
andram
from string to numberWill add linting and testing to Github action later which will be used to validate PR's
Type of change
Please check the relevant option(s):
Prerequisites
The following efforts must be made for the PR to be considered. Please check when completed:
Additional Information (optional)
Provide any additional context or screenshots about the feature or fix here.
example broken json:
example broken schema:
Related Pull Requests / Discussions
If there are other pull requests or discussions related to this change, please link them here: