New Script: Hoarder LXC #567
Conversation
github-actions
bot
added
new script
|
Thanks a lot for all your effort in adding hoarder to proxmox scripts. I'll hopefully be able to review the hoarder side of this PR later tonight! |
Also made similar changes in some other areas.
github-actions
bot
added
breaking change
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
MickLesk
removed
update script
|
Added JSON for website. |
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
…e zip after cleanup
Co-authored-by: Håvard Gjøby Thom <[email protected]>
|
Dont merge the Main Branch ^^ you can switch in GitHub to your pushed Branch and Change your File. Now I have to rewrite your branch so that the changes are not duplicated. |
|
Sorry! Would it be easier if I closed this and submitted a new PR?
…On Fri, Nov 29, 2024, at 8:26 AM, CanbiZ wrote:
Dont merge the Main Branch ^^ you can switch in GitHub to your pushed Branch and Change your File.
Now I have to rewrite your branch so that the changes are not duplicated.
—
Reply to this email directly, view it on GitHub <#567 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQFMUVUFBHH5KCE7NY7CJWL2DBTP5AVCNFSM6AAAAABSVCTPZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBXHAYTOOBUGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
No. I pick the Files later. Next time Switch in GitHub to your Branch and edit the file there. 😄 |
&>/dev/null
| $STD pnpm install --frozen-lockfile | ||
|
|
||
| HOARDER_SECRET=$(openssl rand -base64 36 | cut -c1-24) | ||
| cat <<EOF >/opt/hoarder/.env |
There was a problem hiding this comment.
Should this be in /etc/hoarder/config.env instead?
There was a problem hiding this comment.
While I originally had the env file in /etc/hoarder.env as per your suggestion, it was implied to me that it is not standard to do that for scripts in this repo. I'll leave it up to the maintainers to decide how to proceed with this sort of thing.
| msg_ok "Stopped Services" | ||
| msg_info "Updating ${APP} to v${RELEASE}" | ||
| cd /opt | ||
| mv /opt/hoarder/.env /opt/.env |
There was a problem hiding this comment.
This is another reason why the env files should probably be in /etc/hoarder instead.
| PREV_RELEASE=$(cat /opt/${APP}_version.txt) | ||
| if [[ ! -f /opt/${APP}_version.txt ]] || [[ "${RELEASE}" != "${PREV_RELEASE}" ]]; then | ||
| msg_info "Stopping Services" | ||
| systemctl stop hoarder-web hoarder-workers hoarder-browser |
There was a problem hiding this comment.
Technically, you don't need to stop the browser for a hoarder update
|
Once it lands, I'm planning to advertise it in the wiki as one of the supported installation mechanisms. Thanks a lot for working on this! |
Co-authored-by: Mohamed Bassem <[email protected]>
Note
We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.
Description
With help from @MickLesk and MohamedBasem I have created an LXC install script for Hoarder, the bookmark everything app.
Type of change
Please check the relevant option(s):
Prerequisites
The following efforts must be made for the PR to be considered. Please check when completed:
Additional Information (optional)
Provide any additional context or screenshots about the feature or fix here.
For some reason the bazaar scripts were executable so I changed their modes, that's why you'll see them in this PR. I'll need to learn to not get distracted by little things like that (or make a separate PR) when I try to contribute.
Related Pull Requests / Discussions
If there are other pull requests or discussions related to this change, please link them here: