Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Script: The Lounge IRC #571

Merged
merged 21 commits into from
Nov 29, 2024
Merged

Conversation

quantumryuu
Copy link
Contributor

@quantumryuu quantumryuu commented Nov 28, 2024

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Wanted to try creating an LXC install script. All feedback welcome 😃
I have created an LXC install script for The Lounge the self-hosted web IRC client.
Tried to follow the comments on other pull requests about formatting, github releases etc.

Fixes # (issue)
#501
Project Board

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

The latest version of Node.JS (23.x) is installed from nodesource repo.

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

  • Related PR #

@quantumryuu quantumryuu requested a review from a team as a code owner November 28, 2024 16:24
@github-actions github-actions bot added new script A change that adds a new script website A change to the website labels Nov 28, 2024
ct/thelounge.sh Outdated Show resolved Hide resolved
@quantumryuu quantumryuu reopened this Nov 28, 2024
Copy link
Member

@MickLesk MickLesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Changes needed. Check my comments

ct/thelounge.sh Outdated Show resolved Hide resolved
ct/thelounge.sh Show resolved Hide resolved
ct/thelounge.sh Show resolved Hide resolved
json/thelounge.json Outdated Show resolved Hide resolved
json/thelounge.json Outdated Show resolved Hide resolved
ct/thelounge.sh Outdated Show resolved Hide resolved
ct/thelounge.sh Outdated Show resolved Hide resolved
ct/thelounge.sh Outdated Show resolved Hide resolved
ct/thelounge.sh Outdated Show resolved Hide resolved
ct/thelounge.sh Outdated Show resolved Hide resolved
@quantumryuu quantumryuu changed the title The Lounge IRC New Script: The Lounge IRC Nov 28, 2024
@MickLesk
Copy link
Member

@havardthom I've fixed a few little things, have another look. I think the script looks good so far.

@MickLesk MickLesk requested a review from havardthom November 29, 2024 09:05
@MickLesk MickLesk merged commit 862b72a into community-scripts:main Nov 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new script A change that adds a new script website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants