Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Script: Glance #595

Merged
merged 1 commit into from
Dec 2, 2024
Merged

New Script: Glance #595

merged 1 commit into from
Dec 2, 2024

Conversation

quantumryuu
Copy link
Contributor

@quantumryuu quantumryuu commented Nov 30, 2024

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

!! RECREATED FORK REPO AND CREATED PR AGAIN !!
Created install scripts for Glance
Provide a summary of the changes made and/or reference the issue being addressed.

Fixes # (issue)
#256
Project Board

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Provide any additional context or screenshots about the feature or fix here.
YML example taken from official repo.

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:
Did all the changes on #575 😃

@quantumryuu quantumryuu requested a review from a team as a code owner November 30, 2024 00:04
@github-actions github-actions bot added new script A change that adds a new script website A change to the website labels Nov 30, 2024
@beardcodes
Copy link

I initially created the script for glance and put it under show and tell discussion. looks like it's under review here :)

@quantumryuu
Copy link
Contributor Author

Hey @beardcodes sorry about that! I show it as Backlog in Project Board and didn't see any PRs so I did it.
Sorry once again.

@beardcodes
Copy link

@quantumryuu no problem at all - I am glad we are contributing to the same cause.

@MickLesk MickLesk merged commit 336ea19 into community-scripts:main Dec 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new script A change that adds a new script website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants