Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Script: Jenkins #600

Closed
wants to merge 6 commits into from
Closed

Conversation

quantumryuu
Copy link
Contributor

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Made install script for Jenkins

Fixes # (issue)
#400
Project Board

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Provide any additional context or screenshots about the feature or fix here.

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

  • Related PR #

@quantumryuu quantumryuu requested a review from a team as a code owner November 30, 2024 03:21
@github-actions github-actions bot added new script A change that adds a new script website A change to the website labels Nov 30, 2024
@quantumryuu
Copy link
Contributor Author

I removed the update sections and the ${RELEASE} > /opt/${APP}_version because it can be updated with a simple apt update && apt upgrade!

ct/jenkins.sh Outdated
Comment on lines 56 to 58
check_container_storage
check_container_resources
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Missing? No Update? Then Minimum a msg_ like in Adguard-Home

mc \
sudo \
fontconfig \
openjdk-17-jre
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a available freeware in debian12? Or needed an gpg or something else?

openjdk-17-jre
msg_ok "Installed Dependencies"


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove blank line

msg_ok "Installed Dependencies"


msg_info "Installing Jenkins"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setup Jenkins

Comment on lines 30 to 31
$STD apt-get install -y \
jenkins
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do an oneliner

$STD apt-get update
$STD apt-get install -y \
jenkins
msg_ok "Installed Jenkins"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setup

$STD apt-get install -y \
jenkins
msg_ok "Installed Jenkins"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Service?

@MickLesk
Copy link
Member

MickLesk commented Dec 3, 2024

I removed the update sections and the ${RELEASE} > /opt/${APP}_version because it can be updated with a simple apt update && apt upgrade!

Okay, then do it Like nextpvr or adguardhome 😄

ct/jenkins.sh Outdated
Comment on lines 1 to 53
#!/usr/bin/env bash
source <(curl -s https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func)
# Copyright (c) 2021-2024 community-scripts ORG
# Author: kristocopani
# License: MIT
# https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE

function header_info {
clear
cat <<"EOF"
__ __ _
/ /__ ____ / /__(_)___ _____
__ / / _ \/ __ \/ //_/ / __ \/ ___/
/ /_/ / __/ / / / ,< / / / / (__ )
\____/\___/_/ /_/_/|_/_/_/ /_/____/

EOF
}
header_info
echo -e "Loading..."
APP="Jenkins"
var_disk="4"
var_cpu="2"
var_ram="1024"
var_os="debian"
var_version="12"
variables
color
catch_errors

function default_settings() {
CT_TYPE="1"
PW=""
CT_ID=$NEXTID
HN=$NSAPP
DISK_SIZE="$var_disk"
CORE_COUNT="$var_cpu"
RAM_SIZE="$var_ram"
BRG="vmbr0"
NET="dhcp"
GATE=""
APT_CACHER=""
APT_CACHER_IP=""
DISABLEIP6="no"
MTU=""
SD=""
NS=""
MAC=""
VLAN=""
SSH="no"
VERB="no"
echo_default
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you migrate to new header? Example:

#!/usr/bin/env bash
source <(curl -s https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func)
# Copyright (c) 2021-2024 tteck
# Author: MickLesk (Canbiz) & vhsdream
# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
# Source: https://hoarder.app/

# App Default Values
APP="Hoarder"
var_tags="bookmark"
var_cpu="2"
var_ram="4096"
var_disk="8"
var_os="debian"
var_version="12"
var_unprivileged="1"

# App Output & Base Settings
header_info "$APP"
base_settings

# Core
variables
color
catch_errors

ct/jenkins.sh Outdated
Comment on lines 64 to 66
msg_ok "Completed Successfully!\n"
echo -e "${APP} should be reachable by going to the following URL.
${BL}http://${IP}:8080${CL} \n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you migrate to new footer? Example:

msg_ok "Completed Successfully!\n"
echo -e "${CREATING}${GN}${APP} setup has been successfully initialized!${CL}"
echo -e "${INFO}${YW} Access it using the following URL:${CL}"
echo -e "${TAB}${GATEWAY}${BGN}http://${IP}:3000${CL}"

@quantumryuu quantumryuu deleted the jenkins branch December 26, 2024 11:26
@quantumryuu quantumryuu mentioned this pull request Dec 26, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new script A change that adds a new script website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants