Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stirling-PDF: replace dependency for v0.35.0 and add check and fix in stirling-pdf.sh #614

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

vhsdream
Copy link
Contributor

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Version 0.35.0 of Stirling-PDF now uses qpdf for OCR instead of ocrmypdf. This PR replaces ocrmypdf with qpdf in the install script, and for those with existing installations updating to 0.35.0 and later, checks for and replaces the packages during the update process.

Fixes #590

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

See discussion at #590 for screenshots of the issue.

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

…df.sh

Checks if ocrmypdf is installed and qpdf is not; if true then removes
ocrmypdf and installs qpdf
As of v0.35.0, StirlingPDF now uses qpdf for OCR instead of ocrmypdf.
@vhsdream vhsdream requested a review from a team as a code owner November 30, 2024 15:31
@github-actions github-actions bot added the update script A change that updates a script label Nov 30, 2024
@MickLesk MickLesk merged commit 8301204 into community-scripts:main Dec 2, 2024
1 check passed
@havardthom
Copy link
Contributor

Why are things being merged without approvals?
Is the if check in this PR needed? Will apt-get remove crash the script if it does not find the package? will apt-get install crash the script if the package already exist?

@vhsdream vhsdream deleted the pdf branch December 3, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants