Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Script: Zammad #640

Merged
merged 14 commits into from
Dec 20, 2024
Merged

Conversation

michelroegl-brunner
Copy link
Member

@michelroegl-brunner michelroegl-brunner commented Dec 2, 2024

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Provide a summary of the changes made and/or reference the issue being addressed.

Fixes #642

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Provide any additional context or screenshots about the feature or fix here.

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

  • Related PR #

@michelroegl-brunner michelroegl-brunner requested a review from a team as a code owner December 2, 2024 13:49
@github-actions github-actions bot added new script A change that adds a new script website A change to the website labels Dec 2, 2024
ct/zammad.sh Outdated Show resolved Hide resolved
ct/zammad.sh Outdated Show resolved Hide resolved
ct/zammad.sh Outdated Show resolved Hide resolved
ct/zammad.sh Outdated Show resolved Hide resolved
install/zammad-install.sh Show resolved Hide resolved
install/zammad-install.sh Outdated Show resolved Hide resolved
install/zammad-install.sh Show resolved Hide resolved
install/zammad-install.sh Outdated Show resolved Hide resolved
install/zammad-install.sh Outdated Show resolved Hide resolved
install/zammad-install.sh Outdated Show resolved Hide resolved
install/zammad-install.sh Outdated Show resolved Hide resolved
install/zammad-install.sh Outdated Show resolved Hide resolved
@michelroegl-brunner
Copy link
Member Author

Updated the PR to account for the changes. You can test it on my dev branch: bash -c "$(wget -qLO - https://raw.githubusercontent.com/michelroegl-brunner/ProxmoxVE/refs/heads/DEV/ct/zammad.sh)"

@MickLesk
Copy link
Member

Updated the PR to account for the changes. You can test it on my dev branch: bash -c "$(wget -qLO - https://raw.githubusercontent.com/michelroegl-brunner/ProxmoxVE/refs/heads/DEV/ct/zammad.sh)"

nope

image

@michelroegl-brunner
Copy link
Member Author

Updated the PR to account for the changes. You can test it on my dev branch: bash -c "$(wget -qLO - https://raw.githubusercontent.com/michelroegl-brunner/ProxmoxVE/refs/heads/DEV/ct/zammad.sh)"

nope

image

Can you test again if this was an isolated error? I´ve run the script on 3 hosts now without a problem.
zammad

@litecactus
Copy link

litecactus commented Dec 17, 2024

I'm new to these community scripts but have a successful build on my server.
What is the default container console username and password please?
IP address given after script runs shows a This site can’t be reached 192.168.1.21 refused to connect. though I would expect to be able to connect

@MickLesk
Copy link
Member

I'm new to these community scripts but have a successful build on my server. What is the default container console username and password please? IP address given after script runs shows a This site can’t be reached 192.168.1.21 refused to connect. though I would expect to be able to connect

if you get an user passwort question, your lxc is defect!

@MickLesk
Copy link
Member

@michelroegl-brunner Switch CT to new Default

BramSuurdje
BramSuurdje previously approved these changes Dec 17, 2024
@michelroegl-brunner
Copy link
Member Author

@MickLesk Done!

MickLesk
MickLesk previously approved these changes Dec 18, 2024
MickLesk
MickLesk previously approved these changes Dec 18, 2024
@MickLesk
Copy link
Member

ready for test:

bash -c "$(wget -qLO - https://raw.githubusercontent.com/community-scripts/ProxmoxVE/refs/heads/develop/ct/zammad.sh)"

@florianwilde | @second2falcon
Can you test it?

@litecactus
Copy link

Works for me, thank you

@MickLesk MickLesk merged commit 9379ac4 into community-scripts:main Dec 20, 2024
3 checks passed
@second2falcon
Copy link

@MickLesk sorry for the late response, but it worked for me fine too.

@chrisjenx
Copy link

Just ran this today, failed to setup correctly, the update/running the script again will also say "no installation found"

@michelroegl-brunner
Copy link
Member Author

Please open a issue and fill out the form and dont answer on closed Pull Requests. Thank you!

@chrisjenx
Copy link

Nvm, the issue is with Nginx, should probably create an option in the script to just expose directly so we can use our own reverse proxy

@michelroegl-brunner michelroegl-brunner deleted the zammad branch December 29, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new script A change that adds a new script website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zammad Ticketsystem
6 participants