Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL: Change authentication method from peer to md5 for UNIX sockets #650

Merged

Conversation

michelroegl-brunner
Copy link
Member

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

This PR fixes the Issue #343. I makes the changes suggested by the user.

Fixes #343

Type of change

Please check the relevant option(s):

  • [X ] Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Provide any additional context or screenshots about the feature or fix here.

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

  • Related PR #

@michelroegl-brunner michelroegl-brunner requested a review from a team as a code owner December 3, 2024 08:40
@github-actions github-actions bot added the update script A change that updates a script label Dec 3, 2024
@MickLesk
Copy link
Member

MickLesk commented Dec 3, 2024

Tested? Work Adminer?

@michelroegl-brunner
Copy link
Member Author

Yes, i have tested it and its working as far as i can tell :)
You may test it yourself if you want (https://raw.githubusercontent.com/michelroegl-brunner/ProxmoxVE/refs/heads/dev/ct/postgresql.sh).

@MickLesk
Copy link
Member

MickLesk commented Dec 3, 2024

Can you write a little discussion guide for migrating old instances?

I mean, like my last zigbee2mqtt Guide.

With Adminer Installations and without (Guide to add Adminer manually)

@michelroegl-brunner
Copy link
Member Author

Can you write a little discussion guide for migrating old instances?

I mean, like my last zigbee2mqtt Guide.

With Adminer Installations and without (Guide to add Adminer manually)

Sure, can do. I will have a look at it tomorrow.

@michelroegl-brunner
Copy link
Member Author

@MickLesk
I´ve added a guid on how to install adminer afterwards, as well how to do the changes by yourself. GUIDE

@MickLesk
Copy link
Member

MickLesk commented Dec 5, 2024

Fine for me, need 1 Approve by @havardthom to merge the fix

@havardthom havardthom changed the title Fixes #343 - Postgressqsl PostgreSQL: Change authentication method from peer to md5 for UNIX sockets Dec 5, 2024
@havardthom havardthom merged commit ce545bd into community-scripts:main Dec 5, 2024
2 checks passed
@michelroegl-brunner michelroegl-brunner deleted the postgress_fix branch December 9, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostgreSQL LXC - can't authenticate via Adminer
3 participants