New Script: silverbullet

[dsiebel]

Description

I was looking into Silverbullet today and while installing it in a debian LXC I created this install and update script. Since Silverbullet was already requested (#127) and it's already on the backlog, I figured: why not.

Fixes #127

Type of change

Please check the relevant option(s):

• Bug fix (non-breaking change that resolves an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
• New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

• Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
• Testing performed (I have tested my changes, ensuring everything works as expected)
• Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

I intentionally decided against using the silverbullet upgrade command, since this would require installing and running the entire deno build. Using pre-built binary just feels better for production use.

Ref: https://silverbullet.md/Install/Deno#Upgrading

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

• Related PR #

[MickLesk]

It's not worth checking every line for now, there are so many errors and things that don't fit the conventions of our system.

Please check correspondence objects such as kimai, snipe-it, komga, vikunja, bookstack etc.

[dsiebel]

It's not worth checking every line for now, there are so many errors and things that don't fit the conventions of our system.

Please check correspondence objects such as kimai, snipe-it, komga, vikunja, bookstack etc.

I would really appreciate some pointers then. I used the scripts to install and update Silverbullet on my running Debian LXC, so I am wondering what errors there are.

To be quite frank, it is impossible at the moment to find "the right way" to do things, and I get the feeling it keeps changing with every PR I create..
I looked at traefik, trilium, debian and zoraxy, which I recently updated, when creating the scripts.

I did add some improvements (or so I thought), like checking the service is actually running after install and update. Is this what you are referring to?

[dsiebel]

To visualize my point, this is a side-by-side comparison between the update scripts of vikunja and the newly added silverbullet. The boilerplate code is all the same, the things that are different are because it's a different app that's being installed.

[MickLesk]

Short review only with the mobile phone. We don't do the whole thing with services etc. like this. In general, take a look at current scripts and not the ones you mentioned above, which have not been revised for ages.

[dsiebel]

Thanks for the review! Will address asap.

[dsiebel]

I noticed the project card for silverbullet hasn't moved to "In PR" yet. Can someone take care of it for transparency?

[michelroegl-brunner]

LGTM