Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update post-pve-install.sh #662

Closed
wants to merge 1 commit into from

Conversation

codeislife23
Copy link

Current code doesn't work on v8.3. This will match any version starting with 8., including 8.3 and beyond.

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Provide a summary of the changes made and/or reference the issue being addressed.

Fixes # (issue)

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Provide any additional context or screenshots about the feature or fix here.

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

  • Related PR #

This will match any version starting with 8., including 8.3 and beyond.
@codeislife23 codeislife23 requested a review from a team as a code owner December 3, 2024 19:14
@github-actions github-actions bot added the update script A change that updates a script label Dec 3, 2024
@MickLesk
Copy link
Member

MickLesk commented Dec 3, 2024

Current Code Work on 8 3 smooth. Tested with several Machines.

@newzealandpaul
Copy link
Contributor

It works, and the message mentions supporting 8.0 or later. We don't need to restrict the check to 8.3. Not without overhauling over things also. Thanks for the suggestion but I am closing this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants