Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script path formatting in InstallMethod component #909

Merged

Conversation

BramSuurdje
Copy link
Collaborator

@BramSuurdje BramSuurdje commented Dec 18, 2024

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.


✍️ Description

Provide a summary of the changes made and/or reference the issue being addressed.

This pull request includes a small change to the InstallMethod function in the frontend/src/app/json-editor/_components/InstallMethod.tsx file. The change corrects the script path by removing an unnecessary leading slash.



🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

@BramSuurdje BramSuurdje requested a review from a team as a code owner December 18, 2024 23:28
@github-actions github-actions bot added the website A change to the website label Dec 18, 2024
@MickLesk MickLesk merged commit bda3040 into community-scripts:main Dec 19, 2024
10 checks passed
@BramSuurdje BramSuurdje deleted the fix-json-editor-page-install branch December 19, 2024 09:14
dsiebel pushed a commit to dsiebel/ProxmoxVE that referenced this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unneeded / in script section (json-editor)
2 participants