Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Tooltip component by adding CircleHelp icon and fix instructions in script component #910

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

BramSuurdje
Copy link
Collaborator

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.


✍️ Description

Provide a summary of the changes made and/or reference the issue being addressed.

This pull request includes changes to improve the user interface and functionality of the script items in the application. The most important changes include modifying the conditions for displaying installation instructions, updating the tooltip components, and adding a new icon to the tooltip badges.

Changes to installation instructions:

Updates to tooltip components:


🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

Badge Before:
image

Badge After:
image

…out. Updated TooltipContent max width for better display.
…nal rendering based on item type. Updated text to clarify usage instructions for 'misc' type scripts.
@BramSuurdje BramSuurdje requested a review from a team as a code owner December 19, 2024 00:04
@github-actions github-actions bot added the website A change to the website label Dec 19, 2024
@MickLesk MickLesk merged commit 6f96aeb into community-scripts:main Dec 19, 2024
3 checks passed
@BramSuurdje BramSuurdje deleted the feat-add-icons-to-badges branch December 19, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants