Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for embargo acknowledgement in python and golang backends #4485

Merged
merged 27 commits into from
Dec 5, 2024
Merged

Add support for embargo acknowledgement in python and golang backends #4485

merged 27 commits into from
Dec 5, 2024

Conversation

lukaszgryglicki
Copy link
Contributor

@lukaszgryglicki lukaszgryglicki commented Nov 21, 2024 •
edited
Loading

Adding boolean property signature_embargo_acked to cla-[env]-signatures DynamoDB table and support in python backend.

This property is set to true on all new signatures created, and is not changed for existing signatures. So when a signature is updated - this field is either not changed or set to false (default values), while new signatures have this property set to true.

This is for the ticket: #4482.

This can only be merged when:

  • UI is updated with new embargo checkbox that only allows proceeding when checked.

@lukaszgryglicki lukaszgryglicki self-assigned this Nov 21, 2024
@lukaszgryglicki lukaszgryglicki added blocked Don't merge enhancement New feature or request backend An issue or feature related to the backend services embargo compliance labels Nov 21, 2024
@lukaszgryglicki lukaszgryglicki mentioned this pull request Nov 21, 2024
Open
@lukaszgryglicki
Copy link
Contributor Author

@mlehotskylf CI failures are not related to this PR and lint-test-build seems to be stalled.

@lukaszgryglicki
Sync with AWS env updates
1c0db12 
Signed-off-by: Łukasz Gryglicki <[email protected]>
@lukaszgryglicki
ngrok details
247a9f8 
Signed-off-by: Łukasz Gryglicki <[email protected]>
@lukaszgryglicki
Testing POST '/v1/signature' API
8e02cb1 
Signed-off-by: Łukasz Gryglicki <[email protected]>
@lukaszgryglicki
Python APIs update to also set embargo_acked flag on existing signatu…
3213897 
…res when updating them

Signed-off-by: Łukasz Gryglicki <[email protected]>
@lukaszgryglicki
go fmt
32c9f1d 
Signed-off-by: Łukasz Gryglicki <[email protected]>
nickmango
nickmango previously approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@nickmango nickmango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukaszgryglicki
Ready for review
7aa75a8 
Signed-off-by: Łukasz Gryglicki <[email protected]>
@lukaszgryglicki
Ready for Review
9442e3a 
Signed-off-by: Łukasz Gryglicki <[email protected]>
nickmango
nickmango approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@nickmango nickmango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukaszgryglicki lukaszgryglicki merged commit f786536 into dev Dec 5, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickmango nickmango nickmango approved these changes

@dealako dealako Awaiting requested review from dealako

@mlehotskylf mlehotskylf Awaiting requested review from mlehotskylf

Assignees

@lukaszgryglicki lukaszgryglicki

Labels
backend An issue or feature related to the backend services embargo compliance enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukaszgryglicki @nickmango