Example of better way to manage flags and mocks #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwestacott
reviewed
Nov 25, 2024
| "FLAG_2": getEnvironmentValueAsBoolean("FLAG_2") | ||
| }; | ||
|
|
||
| export const hasFeature = (): FeatureFlags => flags; |
There was a problem hiding this comment.
hasFeature() doesn't return a boolean but a list of feature flag boolean values, so that should be reflected in the function name.
mwestacott
reviewed
Nov 25, 2024
| jest.mock("../utils/feature.flag"); | ||
|
|
||
| (hasFeature as jest.Mock).mockReturnValue({ | ||
| "FLAG_1": false, |
There was a problem hiding this comment.
Could have a pre-defined list of all the feature flags somewhere and then just override to set individual ones to true, in specific tests, when required.
|
A couple of comments but this looks like an improved approach over what we did in ROE. |
|
There is a simpler way to do it using jest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
Change description
Work checklist
Merge instructions
We are committed to keeping commit history clean, consistent and linear. To achieve this commit should be structured as follows:
and contain the following structural elements:
BREAKING CHANGE:introduces a breaking API change (correlating with MAJOR in semantic versioning). A BREAKING CHANGE can be part of commits of any type,fix:andfeat:are allowed, for examplebuild:,chore:,ci:,docs:,style:,refactor:,perf:,test:, and others,BREAKING CHANGE: <description>may be provided.