Skip to content

Commit

Permalink
fix: default imagePullPolicy (#28)
Browse files Browse the repository at this point in the history
* fix: default imagePullPolicy

* chore: bump version 0.9.1 => 0.9.2

* fix: set exports.defaults.image.pullPolicy to null

---------

Co-authored-by: Mohammad Abdolirad <[email protected]>
  • Loading branch information
zevisert and atkrad authored Oct 12, 2023
1 parent 78803f2 commit 1372a39
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions charts/helmet/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ name: helmet
description: Helmet is a library Helm Chart for grouping common logics. This chart is not deployable by itself.
home: https://github.com/companyinfo/helm-charts/blob/main/charts/helmet
type: library
version: "0.10.0"
appVersion: "0.10.0"
version: "0.10.1"
appVersion: "0.10.1"
keywords:
- common
- helper
Expand Down
2 changes: 1 addition & 1 deletion charts/helmet/templates/_deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ spec:
securityContext: {{- omit .Values.containerSecurityContext "enabled" | toYaml | nindent 12 }}
{{- end }}
image: {{ include "common.images.image" (dict "imageRoot" .Values.image "global" .Values.global) }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
imagePullPolicy: {{ default (eq .Values.image.tag "latest" | ternary "Always" "IfNotPresent") .Values.image.pullPolicy }}
{{- if .Values.command }}
command: {{- include "common.tplvalues.render" (dict "value" .Values.command "context" $) | nindent 12 }}
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion charts/helmet/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ exports:
## Defaults to 'Always' if image tag is 'latest', else set to 'IfNotPresent'
## ref: https://kubernetes.io/docs/user-guide/images/#pre-pulling-images
##
pullPolicy: Always
pullPolicy: null

## Optionally specify an array of imagePullSecrets (secrets must be manually created in the namespace)
## ref: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/
Expand Down

0 comments on commit 1372a39

Please sign in to comment.