Merge pull request #17 from companyinfo/add-revision-history-limit-su…

…pport Add custom deployment .spec.revisionHistoryLimit support
companyinfo · Jul 25, 2023 · 3c40d82 · 3c40d82
2 parents 7176586 + f764839
commit 3c40d82
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 6 deletions.
diff --git a/charts/helmet/Chart.lock b/charts/helmet/Chart.lock
@@ -1,6 +1,6 @@
 dependencies:
 - name: common
   repository: https://charts.bitnami.com/bitnami
-  version: 2.2.2
-digest: sha256:76e63a2ff3b4cb7676c9fc2a5c36d5c0d9564b5fe96a4ec7dcc53c2a73e723de
-generated: "2023-01-03T00:57:41.079773012+01:00"
+  version: 2.6.0
+digest: sha256:b729437099044744a7ed5decf9e458569558e9a7a1f084bba521fd0edc084fd4
+generated: "2023-07-25T12:04:37.195150444+02:00"
diff --git a/charts/helmet/Chart.yaml b/charts/helmet/Chart.yaml
@@ -3,8 +3,8 @@ name: helmet
 description: Helmet is a library Helm Chart for grouping common logics. This chart is not deployable by itself.
 home: https://github.com/companyinfo/helm-charts/blob/main/charts/helmet
 type: library
-version: "0.7.0"
-appVersion: "0.7.0"
+version: "0.8.0"
+appVersion: "0.8.0"
 keywords:
   - common
   - helper
@@ -15,5 +15,5 @@ maintainers:
     url: https://company.info
 dependencies:
   - name: common
-    version: "2.2.2"
+    version: "2.6.0"
     repository: "https://charts.bitnami.com/bitnami"
diff --git a/charts/helmet/README.md b/charts/helmet/README.md
@@ -112,6 +112,7 @@ $ helm install nginx .
 | Name                                    | Description                                                                                                              | Value                                                            |
 |-----------------------------------------|--------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------|
 | `replicaCount`                          | Number of APP replicas                                                                                                   | `1`                                                              |
+| `revisionHistoryLimit`                  | The number of old history to retain to allow rollback                                                                    | `10`                                                             |
 | `ports`                                 | List of ports to expose from the container                                                                               | `[{"name": "http", "containerPort": "8080", "protocol": "TCP"}]` |
 | `livenessProbe.enabled`                 | Enable livenessProbe on APP container (only main container)                                                              | `false`                                                          |
 | `readinessProbe.enabled`                | Enable readinessProbe on APP container (only main container)                                                             | `false`                                                          |

diff --git a/charts/helmet/templates/_deployment.yaml b/charts/helmet/templates/_deployment.yaml
@@ -25,6 +25,7 @@ spec:
   {{- if not .Values.autoscaling.enabled }}
   replicas: {{ .Values.replicaCount }}
   {{- end }}
+  revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
   selector:
     matchLabels: {{- include "common.labels.matchLabels" . | nindent 6 }}
   {{- if .Values.updateStrategy }}

diff --git a/charts/helmet/values.yaml b/charts/helmet/values.yaml
@@ -92,6 +92,10 @@ exports:
     ##
     replicaCount: 1
 
+    ## @param revisionHistoryLimit The number of old history to retain to allow rollback
+    ##
+    revisionHistoryLimit: 10
+
     ## List of ports to expose from the container.
     ## ref: https://kubernetes.io/docs/concepts/services-networking/connect-applications-service
     ##