Handle conan.cmake download failures gracefully #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds code to CMakeLists.txt to detect failure to download conan.cmake and handle it gracefully. CMake's `file(DOWNLOAD ...)` command [appears to retain][so] an empty or corrupt file even when the download failed, and it does this silently without issuing any sort of errors or warnings. Currently, once the download failed, subsequent configures and reconfigures will all read from this bad conan.cmake until the build directory is wiped (not even deleting the cache helps). To fix this, we detect download failures explicitly, remove the bad file, and report the error to the user. Also added a SHA256 check to the download command; this is usually redundant with `TLS_VERIFY ON`, but can be helpful against very bad MITM actors (sometimes seen in corporate environments). [so]: https://stackoverflow.com/q/61255773
|
Sorry we never got to this; seems the underlying CMake setup changed substantially and uses a newer way of accessing conan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds code to CMakeLists.txt to detect failure to download conan.cmake and handle it gracefully.
CMake's
file(DOWNLOAD ...)command appears to retain an empty or corrupt file even when the download failed, and it does this silently without issuing any sort of errors or warnings. Currently, once the download failed, subsequent configures and reconfigures will all read from this bad conan.cmake until the build directory is wiped (not even deleting the cache helps). To fix this, we detect download failures explicitly, remove the bad file, and report the error to the user.Also added a SHA256 check to the download command; this is usually redundant with
TLS_VERIFY ON, but can be helpful against very bad MITM actors (sometimes seen in corporate environments).