Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] update tags #135

Merged
merged 1 commit into from
Feb 9, 2025
Merged

[test] update tags #135

merged 1 commit into from
Feb 9, 2025

Conversation

Vipul-Cariappa
Copy link
Collaborator

vgvassilev
vgvassilev approved these changes Feb 9, 2025
View reviewed changes
Copy link

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why the test started to crash?

@Vipul-Cariappa
Copy link
Collaborator Author

Vipul-Cariappa commented Feb 9, 2025 •
edited
Loading

It crashes due to a xfail test. So I have set it to run=False.
The actual reason is due to type mismatch of complex types. The lookup returns _Complex double, but the actual type is std::complex<double>.

@Vipul-Cariappa Vipul-Cariappa merged commit 69a3cf6 into compiler-research:master Feb 9, 2025
58 checks passed
@Vipul-Cariappa Vipul-Cariappa deleted the test-tags branch February 9, 2025 07:55
@Vipul-Cariappa Vipul-Cariappa mentioned this pull request Feb 9, 2025
Merged
@vgvassilev
Copy link

It crashes due to a xfail test. So I have set it to run=False. The actual reason is due to type mismatch of complex types. The lookup returns _Complex double, but the actual type is std::complex<double>.

Ok, in this case we had some complicated logic in maybe CppInterOp or clad to check if a number is complex... The _Complex is a compiler builtin that gets rewired to std::complex at some point...

@Vipul-Cariappa
Copy link
Collaborator Author

Ok, in this case we had some complicated logic in maybe CppInterOp or clad to check if a number is complex... The _Complex is a compiler builtin that gets rewired to std::complex at some point...

One of the attributes of the std::complex class is _Complex. So it is a data member.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgvassilev vgvassilev vgvassilev approved these changes

@aaronj0 aaronj0 Awaiting requested review from aaronj0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vipul-Cariappa @vgvassilev