Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xeus-cpp version to 0.7.0 dev after 0.6.0 release #234

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

mcbarton
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

Now that xeus-cpp 0.6.0 has been released the next version that is been developed needs to be the next commit. Wasn't quite sure what it was so put 0.7.0 for now, and can adjust with further commits as needed.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (ed69a4c) to head (cd44bfd).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   80.72%   80.72%           
=======================================
  Files          19       19           
  Lines         970      970           
  Branches       93       93           
=======================================
  Hits          783      783           
  Misses        187      187           

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@@ -11,7 +11,7 @@

// Project version
#define XEUS_CPP_VERSION_MAJOR 0
#define XEUS_CPP_VERSION_MINOR 6
#define XEUS_CPP_VERSION_MINOR 7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: macro 'XEUS_CPP_VERSION_MINOR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]

#define XEUS_CPP_VERSION_MINOR 7
        ^

@mcbarton mcbarton marked this pull request as ready for review January 27, 2025 14:14
@mcbarton mcbarton merged commit 6bec1a6 into compiler-research:main Jan 27, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants