Skip to content

Commit

Permalink
Fix output for Service Subnets (#770)
Browse files Browse the repository at this point in the history
* Bump to 1.1.3
  • Loading branch information
JohnPreston authored Jun 20, 2024
1 parent 1dc7371 commit 19c2ec0
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 5 deletions.
2 changes: 1 addition & 1 deletion ecs_composex/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@

__author__ = """John Preston"""
__email__ = "[email protected]"
__version__ = "1.1.2"
__version__ = "1.1.3"
11 changes: 9 additions & 2 deletions ecs_composex/ecs/ecs_family/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -300,14 +300,21 @@ def generate_outputs(self):
"""
Generates a list of CFN outputs for the ECS Service and Task Definition
"""
if self.service_networking.security_group:
if (
self.service_compute.launch_type != "EXTERNAL"
and self.service_networking.security_group
):
self.outputs.append(
CfnOutput(
f"{self.logical_name}GroupId",
Value=Ref(self.service_networking.security_group.parameter.title),
)
)
if ecs_params.SERVICE_SUBNETS.title in self.stack.stack_template.parameters:
if (
self.service_networking.subnets_output
and isinstance(self.service_networking.subnets_output, Ref)
and self.service_compute.launch_type != "EXTERNAL"
):
self.outputs.append(
CfnOutput(
ecs_params.SERVICE_SUBNETS.title,
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "ecs_composex"
version = "1.1.2"
version = "1.1.3"
description = "Manage, Configure and Deploy your services and AWS services and applications from your docker-compose definition"
authors = ["John Preston <[email protected]>"]
maintainers = ["John Preston <[email protected]>"]
Expand Down Expand Up @@ -84,7 +84,7 @@ sphinx-material = "^0.0.35"
github_url = "https://github.com/compose-x/ecs_composex"

[tool.tbump.version]
current = "1.1.2"
current = "1.1.3"
regex = '''
(?P<major>\d+)
\.
Expand Down

0 comments on commit 19c2ec0

Please sign in to comment.