-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECS.ContainerDefinition.StopTimeout docker-compose.service.stop_grace_period #718
ECS.ContainerDefinition.StopTimeout docker-compose.service.stop_grace_period #718
Conversation
Hi @JohnPreston , I tried to stick to naming/logging conventions as far as I understand them, but let me know if anything needs tweaking before you merge. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @thorfi
Great stuff as always, thanks for the contribution.
See my notes below and let me know
Co-authored-by: John Preston <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@thorfi can you please fix the indentation/formatting with black? python3 -m pip install pip -U; python -m pip install pre-commit
cd ecs_composex; pre-commit install That way pre-commit will trigger when you do |
Done! Thanks |
Set ECS.ContainerDefinition.StopTimeout from docker-compose.service.stop_grace_period
Fixes #717