Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single-container unset settings on __init__ #721

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

JohnPreston
Copy link
Member

No description provided.

@JohnPreston JohnPreston linked an issue Nov 29, 2023 that may be closed by this pull request
@JohnPreston
Copy link
Member Author

JohnPreston commented Nov 29, 2023

Hey @thorfi
This addresses #719 by ensuring that we capture the ephemeral storage size right away even for single container too.

EDIT: This change and yours are actually quite well complementary

@JohnPreston JohnPreston force-pushed the fix/singleton-family-init-settings branch from f71b56b to 752bad4 Compare November 29, 2023 07:21
Copy link

sonarcloud bot commented Nov 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JohnPreston JohnPreston merged commit 9cd964c into main Nov 29, 2023
4 of 5 checks passed
@JohnPreston JohnPreston deleted the fix/singleton-family-init-settings branch November 29, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] service.deploy.labels: ecs.ephemeral.storage not working
1 participant